From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B9603B3895 for ; Thu, 1 Oct 2026 23:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790896718; cv=none; b=ibmXTRlYrwTJU9U0kBMBw4QEROzZJv9kGsNzV/5nuI/EVfVZY+taOXLHZBDw6Hfh3oAIvTq5zYGoI1LaEMeo8tUQ0bKDbKTIjwgfd03aflAz5oFyTdcZycbFqK0rDwSxMrRoXQooRN1mgAkFx7eoJH/l91s/oAnYfiF4XsSS6XE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790896718; c=relaxed/simple; bh=LGswsnZXJUBGkrzTvqTSLcIHT6gzuUHjJgJwgvTE8fM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MbQRGjdGFGkCS5wLV2mEEpZyppipu032Uypd0lcOSmyuUvZe67uIL9DjkB1NvPdIVFoqePRubeK7KoOkZ/X3bDJOz5vCyu32ApCeGbxKRwaSab6dWuviEGvkQqrXHXIhbh0HEA/9uXwcfz9UzC7LAdcvXisd49K8xlxzPKIq6Bs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GB6KYFb5; arc=none smtp.client-ip=209.85.214.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GB6KYFb5" Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cfc52ddc55so67460855ad.3 for ; Thu, 01 Oct 2026 16:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790896716; x=1791501516; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7Bt4FBOS0I71ZeNU1qvl7TVnImsqea9TvROCXfNFv7c=; b=GB6KYFb5OU5KAXaieAWtPW9+eZVxGHI3jLY2OVL4FuPWCUoUtnpGmCzM91pHEfTCMD blI2zKr8HxssevsDsIPu/RINqwx1MB+Yq1XRe1x6hP/omS2JisYjZxtbzMuTgeT5FrX5 eHbb74KQPzVMuh6XuIBpvxY7q4vXW5rpmdCKEmvbG04rthycnGxr15sTN9k1UkfkV1oR Gy528AW1i0YUPRl6lF/SIh+3ix6YBcgBI/NadtlMrYDhQdE8eqI7HKIFC/JxZ97n1gew DHWKLgiTu9JGMPx2IwwCSF08HYmgir1S/pYoWsFdF8ffK7N5tU40myZuvkv7kAO9Sy3a gCeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790896716; x=1791501516; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7Bt4FBOS0I71ZeNU1qvl7TVnImsqea9TvROCXfNFv7c=; b=SRGPgP/AyJUtagCbpaHM7tMDtP1oSW0TYjvPZa8fAzoiZG4G8sUJZu8xyBwYqj+See yYn08HlGYJQg0iOXlxKOj2bYQanRXTykL/Gn4g2y4PqpAGJfhK79K837jY2wRFWPRS61 O9pNsTESFuvU8I13erRk2AXjx5MkGLEEFHYrlzX84dOkFMnQbsnY9SlEWf/NY1F2Wdml GZL7U2BK/6W71YGdbc1lgPBBcg7OGvjFZOfsDZZ6RTAaqdJr90xBEUn3ILV4jpyXf5lg CooBonbdTck6BbE0LE6omMBIK7vixOH72KsGMNW+HBZbYt2jmXk7AB0MCuu1rXUnPbUu 9ohA== X-Forwarded-Encrypted: i=1; AKwUvBwGjWqRdFu+GxCkSLLd142+gaoVylOJZ/tXk0AMzbv8OQu6CeE2YQPvP4+6kMViVnjDmC1D3noNKRDknvg=@vger.kernel.org X-Gm-Message-State: AFq9FYLbhmHlJB7ckwjYV2OBcrb8hDcv2JhO3YGIax3K0NmshjWEOY64 1MwxT/xs9j0D/o8U5zUr/DITC/Gk8HRbXI1mo2tC5Qk3X9xmzeyBUceoWnQikhHkmcKyu09dRae vaU6luw== X-Received: from pjsc18.prod.google.com ([2002:a17:90a:bf12:b0:3a6:dda6:5b44]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:58e8:b0:39d:fd82:de0c with SMTP id 98e67ed59e1d1-3a6ce3be283mr769245a91.2.1790896716130; Thu, 01 Oct 2026 16:18:36 -0700 (PDT) Date: Thu, 1 Oct 2026 16:18:35 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260929113711.2064390-1-leo.bras@arm.com> <20260929113711.2064390-3-leo.bras@arm.com> Message-ID: Subject: Re: [PATCH v1 2/3] KVM: selftests: Check dirty-ring size before enabling From: Sean Christopherson To: Leonardo Bras Cc: Paolo Bonzini , Shuah Khan , David Matlack , Ackerley Tng , Marc Zyngier , Josh Hilke , Oliver Upton , Wu Fei , Steffen Eiden , Claudio Imbrenda , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, Oct 01, 2026, Leonardo Bras wrote: > On Wed, Sep 30, 2026 at 01:31:25PM -0700, Sean Christopherson wrote: > > > "Dirty-ring not supported in this kernel\n"); > > > > "this kernel" could be misleading, some architectures simply don't support the > > dirty ring. Hmm, the counter argument is that this is actually accurate if those architectures were to gain support in the future, but someone ran this on an older kernel... > So, do you suggest keeping it simple by printing "Dirty-ring not supported"? Yeah, unless you have a better idea. Actually, even though Kconfig isn't user- controllable, it's still there in the .config. So maybe something like this? TEST_ASSERT(cap, "Dirty-ring not supported, check CONFIG_HAVE_KVM_DIRTY_RING?"); That would at least give the user a breadcrumb to start with.