mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Paul Louvel <paul.louvel@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Christophe Leroy <chleroy@kernel.org>
Subject: Re: [PATCH v7 00/20] crypto: talitos - Driver cleanup
Date: Fri, 2 Oct 2026 17:27:53 +1000	[thread overview]
Message-ID: <ar9c-eJtdmlunbt4@gondor.apana.org.au> (raw)
In-Reply-To: <20260923-7-3-rc2_talitos_cleanup-v7-0-9a45261fc097@bootlin.com>

On Wed, Sep 23, 2026 at 05:18:36PM +0200, Paul Louvel wrote:
>
> Sashiko reviews dismissed:
> 
> [1], 1: If this is an issue, it is an existing issue because
> the driver used devm_kzalloc() to allocate an instance of struct
> talitos_crypto_alg.
> Second, how should a driver knows that it should keep this memory
> because a tfm instance is still alive ? For me, the only fix would be to
> use kzalloc() and then never free it, which is not acceptable.
> 
> [2], [3]: A kernel configuration that selects both version is possible,
> but a SoC featuring both hardware version of the crypto engine is not
> possible and not described in any device tree. Freescale MPCxxxx SoC
> family is more than 15+ years old.

Could you please post responses to the new review comments as well?

https://sashiko.dev/#/patchset/20260923-7-3-rc2_talitos_cleanup-v7-0-9a45261fc097%40bootlin.com

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      parent reply	other threads:[~2026-10-02  7:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 15:18 Paul Louvel
2026-09-23 15:18 ` [PATCH v7 01/20] crypto: talitos/hash - Use CRYPTO_AHASH_BLOCK_ONLY API Paul Louvel
2026-09-23 15:18 ` [PATCH v7 02/20] crypto: talitos - Move driver into dedicated directory Paul Louvel
2026-09-23 15:18 ` [PATCH v7 03/20] crypto: talitos - Add missing includes to driver header file Paul Louvel
2026-09-23 15:18 ` [PATCH v7 04/20] crypto: talitos/hwrng - Move into separate file Paul Louvel
2026-09-23 15:18 ` [PATCH v7 05/20] crypto: talitos - Prepare crypto implementation file splitting Paul Louvel
2026-09-23 15:18 ` [PATCH v7 06/20] crypto: talitos/hash - Move into separate file Paul Louvel
2026-09-23 15:18 ` [PATCH v7 07/20] crypto: talitos/skcipher " Paul Louvel
2026-09-23 15:18 ` [PATCH v7 08/20] crypto: talitos/aead " Paul Louvel
2026-09-23 15:18 ` [PATCH v7 09/20] crypto: talitos/hash - Convert to {init,exit}_tfm type-specific API Paul Louvel
2026-09-23 15:18 ` [PATCH v7 10/20] crypto: talitos/skcipher " Paul Louvel
2026-09-23 15:18 ` [PATCH v7 11/20] crypto: talitos/aead " Paul Louvel
2026-09-23 15:18 ` [PATCH v7 12/20] crypto: talitos - Remove alg settings in talitos_register_common() Paul Louvel
2026-09-23 15:18 ` [PATCH v7 13/20] crypto: talitos/hash - Use macro for algorithm definitions Paul Louvel
2026-09-23 15:18 ` [PATCH v7 14/20] crypto: talitos/skcipher " Paul Louvel
2026-09-23 15:18 ` [PATCH v7 15/20] crypto: talitos/aead " Paul Louvel
2026-09-23 15:18 ` [PATCH v7 16/20] crypto: talitos - Introduce is_sec1() helper with static key support Paul Louvel
2026-09-23 15:18 ` [PATCH v7 17/20] crypto: talitos - Replace has_ftr_sec1() with is_sec1() static key helper Paul Louvel
2026-09-23 15:18 ` [PATCH v7 18/20] crypto: talitos - Introduce per-SEC-version descriptor and pointer structures Paul Louvel
2026-09-23 15:18 ` [PATCH v7 19/20] crypto: talitos - Remove TALITOS_DESC_SIZE macro Paul Louvel
2026-09-23 15:18 ` [PATCH v7 20/20] MAINTAINERS: add entry for talitos driver Paul Louvel
2026-10-02  7:27 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar9c-eJtdmlunbt4@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=chleroy@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.louvel@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®