From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Rupesh Majhi <zoone.rupert@gmail.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
"Bill Wendling" <morbo@google.com>,
"David Lechner" <dlechner@baylibre.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Justin Stitt" <justinstitt@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v11 5/5] iio: pressure: dps310: assert the lock at runtime too
Date: Fri, 2 Oct 2026 10:57:04 +0300 [thread overview]
Message-ID: <ar9j0O7DdJ7O1DVk@ashevche-desk.local> (raw)
In-Reply-To: <20261002072526.250081-6-zoone.rupert@gmail.com>
On Fri, Oct 02, 2026 at 10:25:26AM +0300, Rupesh Majhi wrote:
> __must_hold() is clang only and does nothing in GCC builds. Add
> lockdep_assert_held() next to each, so lockdep catches a missing lock
> too.
Suggested-by?
But we need to hear from Jonathan and others if they like these annotations in
a mere IIO driver.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-10-02 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 7:25 [PATCH v11 0/5] iio: pressure: dps310: hardware FIFO support Rupesh Majhi
2026-10-02 7:25 ` [PATCH v11 1/5] iio: pressure: dps310: use devm_mutex_init() Rupesh Majhi
2026-10-02 7:47 ` Andy Shevchenko
2026-10-02 7:25 ` [PATCH v11 2/5] iio: pressure: dps310: read buffered samples from the hardware FIFO Rupesh Majhi
2026-10-02 7:53 ` Andy Shevchenko
2026-10-02 7:25 ` [PATCH v11 3/5] iio: pressure: dps310: derive the drain interval from the watermark Rupesh Majhi
2026-10-02 7:54 ` Andy Shevchenko
2026-10-02 7:25 ` [PATCH v11 4/5] iio: pressure: dps310: implement .hwfifo_flush_to_buffer() Rupesh Majhi
2026-10-02 7:25 ` [PATCH v11 5/5] iio: pressure: dps310: assert the lock at runtime too Rupesh Majhi
2026-10-02 7:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar9j0O7DdJ7O1DVk@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nuno.sa@analog.com \
--cc=zoone.rupert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®