From: Mark Brown <broonie@kernel.org>
To: "Xu, Baojun" <baojun.xu@ti.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Yi, Ken" <k-yi@ti.com>, "Lo, Henry" <henry.lo@ti.com>,
"Chen, Robin" <robinchen@ti.com>,
"Holalu Yogendra, Niranjan" <niranjan.hy@ti.com>,
"pin-hao.huang@hp.com" <pin-hao.huang@hp.com>,
"Syed.SabaKareem@amd.com" <Syed.SabaKareem@amd.com>
Subject: Re: [EXTERNAL] Re: [PATCH v5] ASoC: tas2783-sdw: add firmware download status check
Date: Mon, 21 Sep 2026 11:27:47 +0200 [thread overview]
Message-ID: <arD4k6hCZyqycYYW@sirena.co.uk> (raw)
In-Reply-To: <1c8da29a1fac4435a59783ab9fe7f68b@ti.com>
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
On Mon, Sep 21, 2026 at 09:22:23AM +0000, Xu, Baojun wrote:
> > > + /* Check if the AMP is in reset status. */
> > > + if (val == 0x20) {
> > > + tas_dev->fw_dl_success = false;
> > I'm still not seeing where fw_dl_success gets set to true if the
> > download was skipped.
> If download was skipped, it should be true.
As I said on the previous version can you guarantee that the driver is
being probed with the device having been reset? What happens if
something earlier in the boot process left it running, or the driver was
removed and reprobed? The logic only works currently if the driver did
the download that it's skipping.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-21 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 6:40 Baojun Xu
2026-09-21 8:45 ` Mark Brown
2026-09-21 9:22 ` [EXTERNAL] " Xu, Baojun
2026-09-21 9:27 ` Mark Brown [this message]
2026-09-21 10:08 ` Xu, Baojun
2026-09-21 10:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arD4k6hCZyqycYYW@sirena.co.uk \
--to=broonie@kernel.org \
--cc=13916275206@139.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=henry.lo@ti.com \
--cc=k-yi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=pin-hao.huang@hp.com \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®