From: Mark Brown <broonie@kernel.org>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"DRM XE List" <intel-xe@lists.freedesktop.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
Vinod Govindapillai <vinod.govindapillai@intel.com>
Subject: linux-next: manual merge of the drm-xe tree with the drm-intel tree
Date: Mon, 21 Sep 2026 14:00:55 +0200 [thread overview]
Message-ID: <arEcd0vIRVds2efB@sirena.co.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]
Hi all,
Today's linux-next merge of the drm-xe tree got a conflict in:
drivers/gpu/drm/xe/xe_pci.c
between commit:
41dae8ac5a3e1 ("drm/xe/pm: introduce PM PME support")
from the drm-intel tree and commit:
320662381ca24 ("drm/xe: Poll GT for C6 before D3")
from the drm-xe tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
diff --cc drivers/gpu/drm/xe/xe_pci.c
index b134d90c01a1c,d66d5a0339ae3..0000000000000
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@@ -1380,9 -1379,7 +1379,9 @@@ static int xe_pci_runtime_suspend(struc
{
struct pci_dev *pdev = to_pci_dev(dev);
struct xe_device *xe = pdev_to_xe_device(pdev);
+ unsigned int flags;
+ bool pme_enabled;
- int err;
+ int err, ret;
/*
* We hold an additional reference to the runtime PM to keep PF in D0
@@@ -1393,26 -1390,21 +1392,37 @@@
xe_assert(xe, !IS_SRIOV_VF(xe));
xe_assert(xe, !pci_num_vf(pdev));
+ flags = memalloc_noreclaim_save();
+ pme_enabled = xe->pme.capable && !xe->d3cold.allowed &&
+ pci_enable_wake(pdev, PCI_D3hot, true) == 0;
+ memalloc_noreclaim_restore(flags);
+
+ xe_pm_update_pme_enabled(xe, pme_enabled);
+
err = xe_pm_runtime_suspend(xe);
- if (err)
+ if (err) {
+ if (pme_enabled) {
+ flags = memalloc_noreclaim_save();
+ pci_enable_wake(pdev, PCI_D3hot, false);
+ memalloc_noreclaim_restore(flags);
+
+ xe_pm_update_pme_enabled(xe, false);
+ }
+
return err;
+ }
+ err = xe_pm_wait_all_c6(xe);
+ if (err) {
+ drm_dbg(&xe->drm, "Resuming - GT C6 check failed!");
+ ret = xe_pm_runtime_resume(xe);
+ if (ret) {
+ drm_err(&xe->drm, "Resume failed after suspend was canceled");
+ return ret;
+ }
+ return err;
+ }
+
pci_save_state(pdev);
if (xe->d3cold.allowed) {
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2026-09-21 12:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 12:00 Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-19 23:31 Stephen Rothwell
2025-02-26 1:12 Stephen Rothwell
2025-02-17 0:52 Stephen Rothwell
2024-10-14 3:24 Stephen Rothwell
2024-09-06 3:15 Stephen Rothwell
2024-09-06 3:27 ` Lucas De Marchi
2024-09-11 3:52 ` Stephen Rothwell
2024-09-11 8:43 ` Jani Nikula
2024-08-15 1:37 Stephen Rothwell
2024-08-15 13:51 ` Lucas De Marchi
2024-05-31 3:18 Stephen Rothwell
2024-05-06 2:17 Stephen Rothwell
2024-04-10 1:37 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arEcd0vIRVds2efB@sirena.co.uk \
--to=broonie@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=vinay.belgaumkar@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®