From: Karl Mehltretter <kmehltretter@gmail.com>
To: SJ Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lian Wang <lianux.mm@gmail.com>,
Kunwu Chan <kunwu.chan@gmail.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] mm/damon: preserve temporal quota state for unmeasured PSI goals
Date: Mon, 21 Sep 2026 20:39:27 +0200 [thread overview]
Message-ID: <arF2epnyKAdkwSG-@gmail.com> (raw)
In-Reply-To: <20260921164749.82070-1-sj@kernel.org>
On Mon, Sep 21, 2026 at 09:47:48AM +0100, SJ Park wrote:
> The patch 1 has wrong Fixes: tag, as I replied to it with two options to path
> forward. Speculatively assuming your preferrence is option 2 (adding this
> series with fixed 'Fixes:' tag), I applied this series to damon/next [1] tree
> with the suggested Fixes: tag modification. Let me know if you want the
> options 1 (squash it into the incomplete fix [2] before it is merged into the
> mainline).
>
> Unless you want option 1, and if this series is not added to mm.git in short
> term (~1 week?) with option 1 update, I will ask mm.git maintainer (Andrew
> Morton) to pick this. So, no action from your side is needed for now unless
> you want option 1. If it seems I forgot doing that or you cannot wait for my
> action, please feel free to ping me or Andrew.
>
Hello SJ,
Thanks for reviewing both patches!
I used b73198a47ffe in Fixes because that commit introduced the problem
with the temporal tuner.
I thought a Fixes tag could also point to a commit that is still in a
maintainer tree. The tip handbook describes that for tip [1], though mm
may handle it differently.
The hash can still change in mm-unstable, so the tag may need updating.
I also found this reply from Andrew [2]. He says he tracks these fixes
by filename and folds them into the original patch before moving it to
non-rebasing git.
Maybe squashing is indeed simpler here, also for backports.
So either option is fine with me. I'll leave that to you and Andrew.
[1] https://docs.kernel.org/process/maintainer-tip.html#ordering-of-commit-tags
[2] https://lore.kernel.org/r/20260313091738.354244f6fb500bef3bad1fa1@linux-foundation.org/
Thanks,
Karl
next prev parent reply other threads:[~2026-09-21 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 2:00 Karl Mehltretter
2026-09-21 2:00 ` [PATCH v2 1/2] mm/damon/core: keep the temporal tuner quota over an unmeasured PSI round Karl Mehltretter
2026-09-21 16:36 ` SJ Park
2026-09-21 2:00 ` [PATCH v2 2/2] mm/damon/tests/core-kunit: test PSI goal values with explicit samples Karl Mehltretter
2026-09-21 16:40 ` SJ Park
2026-09-21 16:47 ` [PATCH v2 0/2] mm/damon: preserve temporal quota state for unmeasured PSI goals SJ Park
2026-09-21 18:39 ` Karl Mehltretter [this message]
2026-09-22 6:28 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arF2epnyKAdkwSG-@gmail.com \
--to=kmehltretter@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kunwu.chan@gmail.com \
--cc=lianux.mm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®