From: Sabrina Dubroca <sd@queasysnail.net>
To: Hui Peng <benquike@gmail.com>
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfrm: reject sub-32-bit or unaligned alg_trunc_len in attach_auth_trunc()
Date: Mon, 21 Sep 2026 17:34:27 +0200 [thread overview]
Message-ID: <arFOgwhswr1MoKVm@krikkit> (raw)
In-Reply-To: <20260919210623.3030144-1-benquike@gmail.com>
I'm really confused here.
2026-09-19, 21:06:23 +0000, Hui Peng wrote:
> In attach_auth_trunc(), userspace supplies `ualg->alg_trunc_len` (in
> bits) via XFRMA_ALG_AUTH_TRUNC, and attach_auth_trunc() only checks that
> `ualg->alg_trunc_len <= algo->uinfo.auth.icv_fullbits`.
>
> However, ESP and AH convert `alg_trunc_len` to bytes via `esp_authsize =
> ALIGN(x->aalg->alg_trunc_len, 8) >> 3` or `ah_authsize =
> x->aalg->alg_trunc_len >> 3`, and pass `authsize` to
Did your LLM make this up? My kernel sources don't have any of this.
> `crypto_aead_setauthsize()` or `ah_init_state()`. If `alg_trunc_len` is
> not a multiple of 8 bits (or is between 1 and 31 bits), integer division
> by 8 truncates the requested bit length (for example, `alg_trunc_len ==
> 7` yields a 0-byte ICV in AH, or `alg_trunc_len` not divisible by 8
and what problem does that pose exactly, for each of those cases?
--
Sabrina
next prev parent reply other threads:[~2026-09-21 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 21:06 Hui Peng
2026-09-21 15:34 ` Sabrina Dubroca [this message]
2026-09-21 22:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arFOgwhswr1MoKVm@krikkit \
--to=sd@queasysnail.net \
--cc=benquike@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®