From: Oleg Nesterov <oleg@redhat.com>
To: Ye Liu <ye.liu@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>, Ye Liu <liuye@kylinos.cn>,
Michal Hocko <mhocko@suse.com>, SJ Park <sj@kernel.org>,
Gregory Price <gourry@gourry.net>,
Lorenzo Stoakes <ljs@kernel.org>,
peterz@infradead.org, paulmck@kernel.org, mingo@redhat.com,
rostedt@goodmis.org, jpoimboe@kernel.org, mic@digikod.net,
tglx@kernel.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com,
rafael@kernel.org, gnoack3000@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rcu@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, rientjes@google.com,
shakeel.butt@linux.dev, xu.xin16@zte.com.cn,
chengming.zhou@linux.dev, will@kernel.org, boqun@kernel.org,
frederic@kernel.org, neeraj.upadhyay@kernel.org,
joelagnelf@nvidia.com, josh@joshtriplett.org, urezki@gmail.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
tony.luck@intel.com, reinette.chatre@intel.com, x86@kernel.org,
paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
pavel@kernel.org, lance.yang@linux.dev, mhiramat@kernel.org,
pmladek@suse.com, longman@redhat.com,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
qiang.zhang@linux.dev, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, mark.rutland@arm.com,
Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com
Subject: Re: [PATCH v4 03/15] mm/ksm: convert process iterator to for_each_process_rculock
Date: Mon, 21 Sep 2026 21:59:37 +0200 [thread overview]
Message-ID: <arGMqePU2L4q33o_@redhat.com> (raw)
In-Reply-To: <20260921092101.89285-4-ye.liu@linux.dev>
On 09/21, Ye Liu wrote:
>
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -3280,8 +3280,7 @@ void collect_procs_ksm(const struct folio *folio, const struct page *page,
> struct anon_vma *av = rmap_item->anon_vma;
>
> anon_vma_lock_read(av);
> - rcu_read_lock();
> - for_each_process(tsk) {
> + for_each_process_rculock(tsk) {
> struct anon_vma_chain *vmac;
> const unsigned long addr = rmap_item->address & PAGE_MASK;
> const unsigned long index = rmap_item->linear_page_index;
> @@ -3298,7 +3297,6 @@ void collect_procs_ksm(const struct folio *folio, const struct page *page,
> }
> }
> }
> - rcu_read_unlock();
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2026-09-21 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:20 [PATCH v4 00/15] sched: introduce for_each_process_rculock and for_each_thread_rculock Ye Liu
2026-09-21 9:20 ` [PATCH v4 01/15] " Ye Liu
2026-09-21 9:20 ` [PATCH v4 02/15] mm/oom_kill: convert process/thread iterators to for_each_*_rculock Ye Liu
2026-09-21 19:58 ` Oleg Nesterov
2026-09-21 9:20 ` [PATCH v4 03/15] mm/ksm: convert process iterator to for_each_process_rculock Ye Liu
2026-09-21 19:59 ` Oleg Nesterov [this message]
2026-09-21 9:20 ` [PATCH v4 04/15] mm/memory-failure: " Ye Liu
2026-09-21 9:20 ` [PATCH v4 05/15] cpu/hotplug: " Ye Liu
2026-09-21 9:20 ` [PATCH v4 06/15] freezer: convert thread iterator to for_each_thread_rculock Ye Liu
2026-09-21 9:20 ` [PATCH v4 07/15] hung_task: convert process/thread iterators to for_each_*_rculock Ye Liu
2026-09-21 9:20 ` [PATCH v4 08/15] locking/lockdep: " Ye Liu
2026-09-21 9:20 ` [PATCH v4 09/15] rcu: convert process/thread iterator to for_each_process_thread_rculock Ye Liu
2026-09-21 16:09 ` Paul E. McKenney
2026-09-21 9:20 ` [PATCH v4 10/15] sched: convert process/thread iterators to for_each_*_rculock Ye Liu
2026-09-21 9:20 ` [PATCH v4 11/15] tracing/fgraph: convert process/thread iterator to for_each_process_thread_rculock Ye Liu
2026-09-21 9:20 ` [PATCH v4 12/15] unwind: " Ye Liu
2026-09-21 9:20 ` [PATCH v4 13/15] fs: convert process/thread iterators to for_each_*_rculock Ye Liu
2026-09-21 9:33 ` [PATCH v4 14/15] lib: convert process iterator to for_each_process_rculock Ye Liu
2026-09-21 20:12 ` Oleg Nesterov
2026-09-21 9:33 ` [PATCH v4 15/15] security/landlock: convert thread iterator to for_each_thread_rculock Ye Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arGMqePU2L4q33o_@redhat.com \
--to=oleg@redhat.com \
--cc=Dave.Martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=babu.moger@amd.com \
--cc=boqun@kernel.org \
--cc=bsegall@google.com \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=gnoack3000@gmail.com \
--cc=gourry@gourry.net \
--cc=james.morse@arm.com \
--cc=jiangshanlai@gmail.com \
--cc=jmorris@namei.org \
--cc=joelagnelf@nvidia.com \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=lance.yang@linux.dev \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=liuye@kylinos.cn \
--cc=ljs@kernel.org \
--cc=longman@redhat.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=mic@digikod.net \
--cc=mingo@redhat.com \
--cc=nao.horiguchi@gmail.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=qiang.zhang@linux.dev \
--cc=rafael@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=serge@hallyn.com \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=urezki@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xu.xin16@zte.com.cn \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®