From: Mike Rapoport <rppt@kernel.org>
To: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Cc: akpm@linux-foundation.org, peterx@redhat.com, surenb@google.com,
aarcange@redhat.com, david@kernel.org, ljs@kernel.org,
liam@infradead.org, vbabka@kernel.org, mhocko@suse.com,
shuah@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte()
Date: Tue, 22 Sep 2026 08:58:32 +0300 [thread overview]
Message-ID: <arIZCIiecnNWPtx3@kernel.org> (raw)
In-Reply-To: <20260919004630.1159895-1-donggeunyoo.kernel@gmail.com>
Hi,
On Sat, Sep 19, 2026 at 09:46:28AM +0900, Donggeun Yoo wrote:
> UFFDIO_MOVE on a swapped-out page installs the source PTE at the
> destination unchanged, so a uffd bit set on the source lands in a
> destination VMA that was never registered for write protection, and
> nothing clears it afterwards. Patch 1 clears the bit unless the
> destination is RWP-registered, which is what the present-page and
> zeropage move paths already do. Patch 2 adds the test that catches it.
This and changelogs read like an LLM generated text.
Please add attribution as per
https://docs.kernel.org/process/coding-assistants.html#attribution
> x86_64 defconfig plus USERFAULTFD, TRANSPARENT_HUGEPAGE, GUP_TEST and a
> swap device, under QEMU, base 17e7b8eacf4c:
>
> uffd-unit-tests before after
> move-swap-wp on anon not ok ok
> the other 114 unit tests ok ok
> uffd-wp-mremap, 38 tests ok ok
>
> pagemap bit 57 at the destination before after
> swapped page, dst not armed set clear
> swapped page, dst WP-armed set clear
> swapped page, dst RWP-armed set set
> resident page, dst WP-armed clear clear
>
> MADV_COLLAPSE over 2 MB at dst EINVAL 0
>
> Donggeun Yoo (2):
> userfaultfd: clear the inherited uffd bit in move_swap_pte()
> selftests/mm: add a test for UFFDIO_MOVE of a write-protected swap
> entry
>
> mm/userfaultfd.c | 2 +
> tools/testing/selftests/mm/uffd-unit-tests.c | 61 ++++++++++++++++++++
> 2 files changed, 63 insertions(+)
>
>
> base-commit: 17e7b8eacf4cac800a4fc89a28729df72a2dabda
> --
> 2.53.0
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-09-22 5:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 0:46 Donggeun Yoo
2026-09-19 0:46 ` [PATCH v1 1/2] " Donggeun Yoo
2026-09-22 6:45 ` Mike Rapoport
2026-09-22 12:47 ` Donggeun Yoo
2026-09-22 11:40 ` David Hildenbrand (Arm)
2026-09-22 12:41 ` Donggeun Yoo
2026-09-22 16:45 ` Mike Rapoport
2026-09-23 11:20 ` Kiryl Shutsemau
2026-09-23 11:18 ` Kiryl Shutsemau
2026-09-19 0:46 ` [PATCH v1 2/2] selftests/mm: add a test for UFFDIO_MOVE of a write-protected swap entry Donggeun Yoo
2026-09-22 5:58 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arIZCIiecnNWPtx3@kernel.org \
--to=rppt@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=donggeunyoo.kernel@gmail.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®