From: Christoph Hellwig <hch@infradead.org>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Joanne Koong <joannelkoong@gmail.com>,
Brian Foster <bfoster@redhat.com>,
Damien Le Moal <dlemoal@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Daniel Gomez <da.gomez@samsung.com>,
Pankaj Raghav <p.raghav@samsung.com>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 3/3] iomap: don't lose a failed direct I/O bio's error when zeroing the tail
Date: Tue, 22 Sep 2026 05:28:42 -0700 [thread overview]
Message-ID: <arJ0eljPZIuj5PFD@infradead.org> (raw)
In-Reply-To: <arJF9USiUqIEWB1M@andreayoga.localdomain>
On Tue, Sep 22, 2026 at 11:10:13AM +0200, Andrea Parri wrote:
> > > Why ssize_t? iomap_dio_zero returns int, right?
> >
> > More importantly iomap_dio_zero can only return an error for a
> > logic bomb assert using WARN_ON. I'd suggest to simply return without
> > an error there and remove the handling of the iomap_dio_zero return
> > value entirely, as it clearly casues more harm than it helps.
>
> Agreed, that's cleaner than retyping the local. I'll drop the
> zerror/ret handling entirely for v2 and just call iomap_dio_zero()
> without capturing its return.
Please drop the return value from iomap_dio_zero entirely.
next prev parent reply other threads:[~2026-09-22 12:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 8:31 [PATCH 0/3] iomap: fix error handling regressions Andrea Parri
2026-09-21 8:31 ` [PATCH 1/3] iomap: don't resubmit an ioend after ->writeback_submit() failed Andrea Parri
2026-09-21 22:29 ` Darrick J. Wong
2026-09-22 5:34 ` Christoph Hellwig
2026-09-22 8:53 ` Andrea Parri
2026-09-22 5:33 ` Christoph Hellwig
2026-09-22 9:03 ` Andrea Parri
2026-09-22 12:29 ` Christoph Hellwig
2026-09-21 8:31 ` [PATCH 2/3] iomap: don't lose a fiemap iteration error when emitting the last extent Andrea Parri
2026-09-21 22:31 ` Darrick J. Wong
2026-09-22 5:34 ` Christoph Hellwig
2026-09-21 8:31 ` [PATCH 3/3] iomap: don't lose a failed direct I/O bio's error when zeroing the tail Andrea Parri
2026-09-21 22:34 ` Darrick J. Wong
2026-09-22 5:36 ` Christoph Hellwig
2026-09-22 9:10 ` Andrea Parri
2026-09-22 12:28 ` Christoph Hellwig [this message]
2026-09-21 18:07 ` [PATCH 0/3] iomap: fix error handling regressions Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arJ0eljPZIuj5PFD@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=da.gomez@samsung.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=parri.andrea@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®