From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed2-f35.google.com (mail-ed2-f35.google.com [74.125.228.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30CA74D6C34 for ; Tue, 22 Sep 2026 09:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790070707; cv=none; b=glvzAcisLKU9u1yzegy/7881SN+tkRXlHKow3XjO1sLB0AyyzjxOKbrn2/MdK4ZHXYnBEBn02E1tAvuJLLkmrxFgKC/aixVE/AwgOlslAPPpf9VB7ZS1Bq+Hw3/IvQsmOvUpmv8EhS15tULJOf6z9eeJXxpXSoadIbkSqp8Nc+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790070707; c=relaxed/simple; bh=ZBPCUNSzlh8OrE7I3vX7kLf5GHZkpBuPSmSzeXxhF/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EZkRk4QijSm2MURy0qxP13e804HfugmqsyvvM9kIQ01Z6EEjQx5n3QzB2ykFQ4Hgx8vvDuFWfNf8ORhm+ZtJu3NxapmVXWOMkPCv4h9uiXCER3ifOa+0Ir5vrIgXAWzEj2ODWvHKd9wVAhzLeCavcdNibDrdWcZ8YnbsofFsMs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JV+oi2st; arc=none smtp.client-ip=74.125.228.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JV+oi2st" Received: by mail-ed2-f35.google.com with SMTP id 4fb4d7f45d1cf-6aa1da63791so4917244a12.1 for ; Tue, 22 Sep 2026 02:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790070701; x=1790675501; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0ojJwuub1Y4MtscC/4lreaXIfEEy9YAbRM1nlvmy108=; b=JV+oi2st557afPOPicddWXalRHHtnM7WNv5Mq4UzWwFx/9wBUdQWoUQmG08EIBEJts 5h0R3ALakbAEj7Ee6JDQSEFLbaaNTlh7Nd9OVhO35kf4Zf8eG6fSSYw2R7Ff/0XA34wB Ahkki4Mobza8/mbhuR7r/NrM126sPnYsQslvRL4OdlkhgqpH9a0/pcDXYkXGlRR2ksv3 TSzQ6/E2FJUlgcdboaAiWYLgyJ/3vVo+pgbZBtzQz+1o9yPj/i5ydqDyZvN8iL60PSHH BCVbdVHFIMhnLdgjmfvEMFcucqQUP/e9H3BqEYEWr8t86ektI4vAPeKu5ynUQx2QAkta HRcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790070701; x=1790675501; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0ojJwuub1Y4MtscC/4lreaXIfEEy9YAbRM1nlvmy108=; b=RA7mQ+GGJ2rAqm5mAuczkGUHzc65zmvK15CjStAw6NaA30+BxEGDHlEPjenKholCm5 f+UKbag5DTvp5lN1sx7S/iquB9h7tGBudIdvjCuBKTr8YRbYAG0meykJKWGHPc0OJx48 TD0wz4nafxgr8MpImHSA7s1sVJiCPRybBlwyltsVYBwiDDNmaeaFeFxvdHQ8GG0BQ4dD aHHv//+zOLi6rssgdQ21lajNSznDdwUQ5ADK4oNA/EF1+qK7FgnOrCOPuVJVSNPulfZI +9kzzZbRrlWtZ260kbwM17xYr1NiP/TS4QblDLYYKlyM57iE7NlseFiG/re9xUQ/nErp HT3A== X-Forwarded-Encrypted: i=1; AKwUvBwjldAc5MtaA3XlAsuAs8bGXW9hk6x1CscQyebv8R/wmTJxE09be4CiVBAF8XYJdhJRIEx6ar4riell5E0=@vger.kernel.org X-Gm-Message-State: AFuF++nsz6Gq03jfEJ0ebJqXRAU5mG5cSZL6kHBXnVegP8JexaYCgtVs BrEAb22iXyIaShp2qlOWpkTo4ti3cH8vfmqQtX8S6wAASwinAC/Ozlqu X-Gm-Gg: AYBFou1X5/4dUNu1Ob3/jMNtHHU8R+ynHpkLzIWM8d/bh19oiOCU6PjClZtOqx/mwWF PFNz7EKjLSrOokwG/QgHsWbB0VkhT8/ix+j3dYranTJfuJ3UzqXNFRzCDWZMo95eyPz8Y3Lw4OX URkqNHD7etbisuvg6jFdIa0N1A+wiyx+/rj3/qKMHwmY62ywEVavDRm/XAAm96y29wPBDu7yPF/ kEWFSWhgt6h/jTlLW5lC9Ry7Fbzd7rylqaemOvnA/UoRF7rVU8CffnMdeMynfjcxF4J9by8kz08 BjImaKT5WSOUZWFXWBNoB5fun4TzM4823f+iHztSxrcYT1RJg8jflF8fMlu/KYKpZaYZDtf+F1Q VZMSoBp+IVpvx2tfYJtjebiw5sA90NaztBTTBhEjZ8VtqSmQU8yRBdIHIbH7Ksv+qmg+dcTQfQH tONBE5I3nT53U591X4koDZyr5pW30DdEBe0wQltgIE8RHWjSKS7Y3ZMlJWVt+qxhKYA5p1BJxVg LjOhg== X-Received: by 2002:a05:6402:e04:b0:6a9:946a:d085 with SMTP id 4fb4d7f45d1cf-6aa53142126mr11493309a12.19.1790070700342; Tue, 22 Sep 2026 02:51:40 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6aaa4510c0fsm709687a12.23.2026.09.22.02.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 02:51:39 -0700 (PDT) Date: Tue, 22 Sep 2026 12:51:36 +0300 From: Dan Carpenter To: Guangshuo Li Cc: Markus Elfring , platform-driver-x86@vger.kernel.org, Bao Cheng Su , Benedikt Niedermayr , Hans de Goede , Henning Schild , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Tobias Schaffner , stable@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] platform/x86: simatic-ipc: fix platform device leak on registration failure Message-ID: References: <20260921075312.120983-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 22, 2026 at 04:13:17PM +0800, Guangshuo Li wrote: > > Would it make sense to share the cleanup path and rely on > platform_device_unregister() handling NULL/ERR_PTR, like this? > > +static void unregister_platform_devices(void) > +{ > + platform_device_unregister(ipc_wdt_platform_device); > + platform_device_unregister(ipc_led_platform_device); > + platform_device_unregister(ipc_batt_platform_device); > +} Having one magical cleanup function is the most bug prone way to write cleanup. Use an unwind ladder. https://staticthinking.wordpress.com/2022/04/28/free-the-last-thing-style/ regards, dan carpenter