From: Hangbin Liu <hangbin.liu@linux.dev>
To: Andrea Mayer <andrea.mayer@uniroma2.it>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Hangbin Liu <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net-next 5/5] selftests: seg6: add End.X PSP selftest
Date: Wed, 23 Sep 2026 09:48:08 +0800 [thread overview]
Message-ID: <arMv2FE49vEwM7BP@fedora> (raw)
In-Reply-To: <20260922-srv6_flavors_endx-v1-5-4d01c05c47b7@kylinos.cn>
On Tue, Sep 22, 2026 at 04:54:47PM +0800, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
>
> The current selftest only exercises End with PSP. Add a new test that
> uses End.X on the PSP path so the kernel's End.X flavor handling is
> validated end to end.
>
> Extend __setup_rt_policy() to parse End.X action field from the
> router description, allowing entries like:
> 4:psp:End.X,4,2
> 3:psp:End.X,3,1
>
> Since SETUP_ERR is not set in one setup function, and the middle test may
> set ret to 1, we also need to check ret before setting the result as SKIP.
>
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
> ---
> .../testing/selftests/net/srv6_end_flavors_test.sh | 83 ++++++++++++++++++++--
> 1 file changed, 78 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/net/srv6_end_flavors_test.sh b/tools/testing/selftests/net/srv6_end_flavors_test.sh
> index 52731983b4cc..e130d0d71b3d 100755
> --- a/tools/testing/selftests/net/srv6_end_flavors_test.sh
> +++ b/tools/testing/selftests/net/srv6_end_flavors_test.sh
[...]
>
> +setup_endx_flv_psp()
> +{
> + # Direction hs-1 -> hs-2 (End.X PSP flavor)
> + # SID List=fcff:3::e,fcff:4::ef1,cafe::2
> + # - rt-1 (SRv6 H.Insert policy)
> + # - rt-3 (SRv6 End behavior)
> + # - rt-4 (SRv6 End.X flavor PSP with SL=1)
> + # - rt-2 (Route to hs-2 via nh and oif)
Oh, just noticed that I made a mistake comment. It should be
# - rt-4 (SRv6 End.X flavor PSP with SL=1, route to rt-2 via nh and oif)
# - rt-2 (Route to hs-2 with same subnet)
> + #
> + # Direction hs-2 -> hs-1 (End.X PSP flavor)
> + # SID List=fcff:3::ef1,cafe::1
> + # - rt-2 (SRv6 H.Insert policy)
> + # - rt-3 (SRv6 End.X flavor PSP with SL=1)
> + # - rt-1 (Route to hs-1 via nh and oif)
Same here.
> + setup_rt_policy_ipv6 2 1 "3:noflv:End 4:psp:End.X,4,2"
> + setup_rt_policy_ipv6 1 2 "3:psp:End.X,3,1"
Thanks
Hangbin
prev parent reply other threads:[~2026-09-23 1:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 8:54 [PATCH net-next 0/5] seg6: add End.X PSP flavor support and selftests Hangbin Liu
2026-09-22 8:54 ` [PATCH net-next 1/5] seg6: split final End process out of flavor processing Hangbin Liu
2026-09-23 11:46 ` Andrea Mayer
2026-09-24 8:11 ` Hangbin Liu
2026-09-22 8:54 ` [PATCH net-next 2/5] seg6: add RFC8986 flavor support for End.X Hangbin Liu
2026-09-23 16:05 ` Andrea Mayer
2026-09-24 10:55 ` Hangbin Liu
2026-09-24 11:57 ` netdev-bot+sashiko
2026-09-22 8:54 ` [PATCH net-next 3/5] selftests: seg6: move SRv6 End PSP setup into its own helper Hangbin Liu
2026-09-24 11:57 ` netdev-bot+sashiko
2026-09-22 8:54 ` [PATCH net-next 4/5] selftest: seg6: add explicit cleanup for SRv6 End PSP test Hangbin Liu
2026-09-24 11:57 ` netdev-bot+sashiko
2026-09-22 8:54 ` [PATCH net-next 5/5] selftests: seg6: add End.X PSP selftest Hangbin Liu
2026-09-23 1:48 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arMv2FE49vEwM7BP@fedora \
--to=hangbin.liu@linux.dev \
--cc=andrea.mayer@uniroma2.it \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®