From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <netdev-bot+sashiko@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<sgoutham@marvell.com>
Subject: Re: [PATCH net-next] octeontx2-af: Representor devlink id and port mapping
Date: Wed, 23 Sep 2026 07:15:03 +0530 [thread overview]
Message-ID: <arMvH_s-bER6fpGo@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <179005417560.2160803.15313824484958555300@kernel.org>
On 2026-09-22 at 10:46:15, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:
> Thank you for your contribution! Sashiko AI review found 8 potential
> issue(s) to consider.
>
> Critical: 0 · High: 2 (1) · Medium: 5 (1) · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The new cached fast path in rvu_mbox_handler_get_rep_cnt()
> (af/rvu_rep.c:489-495) returns success before the relocated…
> - [High] The patch turns MBOX_MSG_GET_REP_CNT from 'last caller wins'
> into 'first caller wins, permanently'.
> - [Medium] Commit message omits a functional rewrite of
> rvu_mbox_handler_get_rep_cnt().
> - [Medium] Everything the patch adds is dead code with no in-tree
> consumer, yet it permanently changes a shared AF<->PF mailbox wire…
> - [Medium] struct esw_cfg_req (MBOX_MSG_ESW_CFG, id 0x00e) is extended by
> switch_id[MAX_PHYS_ITEM_ID_LEN] + switch_id_len (sizeof grows from 32…
> - [Medium] The new comment block above struct esw_cfg_req
> (af/mbox.h:1787-1804), duplicated at af/rvu_rep.c:458 and…
> - [Medium] The patch introduces a lockless publish/subscribe protocol for
> rvu->rep2pfvf_map / rvu->rep_cnt but omits the release/acquire pairing…
> - [Low] rvu_sw_port_id() (af/rvu_rep.c:208-226) duplicates, verbatim, the
> linear rep2pfvf_map[] search implemented immediately above it in…
Will address in v2.
pw-bot: changes-requested
prev parent reply other threads:[~2026-09-23 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 5:00 Ratheesh Kannoth
2026-09-22 5:16 ` netdev-bot+sashiko
2026-09-23 1:45 ` Ratheesh Kannoth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arMvH_s-bER6fpGo@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®