From: Herbert Xu <herbert@gondor.apana.org.au>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Haren Myneni <haren@us.ibm.com>,
Dan Streetman <ddstreet@ieee.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-crypto@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/842: depend on the decompressor for KUnit tests
Date: Wed, 23 Sep 2026 18:51:03 +1000 [thread overview]
Message-ID: <arOS954lq6Il5E_N@gondor.apana.org.au> (raw)
In-Reply-To: <20260917055645.26780-1-kmehltretter@gmail.com>
On Thu, Sep 17, 2026 at 07:56:45AM +0200, Karl Mehltretter wrote:
> 842_DECOMPRESS_KUNIT_TEST selects the decompressor even when no other
> option needs it, including through KUNIT_ALL_TESTS.
>
> Depend on 842_DECOMPRESS as required by
> Documentation/dev-tools/kunit/style.rst. This also prevents the test from
> promoting a modular decompressor to built-in.
>
> Fixes: cca072cb1423 ("lib/842: add KUnit tests for the decompressor")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Closes: https://lore.kernel.org/r/CAMuHMdVcZ5cV4-HrjLYfFKh6UshiVxq5eXCNyp0Z1k_SMAvF5g@mail.gmail.com/
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Follow-up to the accepted commit, based on cryptodev-2.6/master.
>
> Testing: Checked Kconfig dependency resolution for eight x86_64
> configurations before and after the change, including KUNIT_ALL_TESTS
> and modular/built-in combinations.
>
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-09-23 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 5:56 Karl Mehltretter
2026-09-21 7:56 ` David Gow
2026-09-23 8:51 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arOS954lq6Il5E_N@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=brendan.higgins@linux.dev \
--cc=david@davidgow.net \
--cc=ddstreet@ieee.org \
--cc=geert@linux-m68k.org \
--cc=haren@us.ibm.com \
--cc=kmehltretter@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=raemoar63@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®