From: Srikar Dronamraju <srikar@linux.ibm.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "scripts/faddr2line: Combine three readelf calls into one"
Date: Wed, 23 Sep 2026 14:56:04 +0530 [thread overview]
Message-ID: <arObLLalNd_fMi2u@linux.ibm.com> (raw)
In-Reply-To: <aqiqScJg8Ey5QnKl@linux.ibm.com>
* Srikar Dronamraju <srikar@linux.ibm.com> [2026-09-15 07:45:37]:
> * Josh Poimboeuf <jpoimboe@kernel.org> [2026-09-14 12:00:26]:
Hi Josh,
> > > With the revert, we end up calling readelf three times but this should
> > > still be fine since calling faddr2line is a debug tool.
> > >
> > > Fixes: b8d9d9496c1e ("scripts/faddr2line: Combine three readelf calls into one")
> > > Signed-off-by: Srikar Dronamraju <srikar@linux.ibm.com>
> >
> > Can you run
> >
> > bash -x scripts/faddr2line ./vmlinux need_active_balance+0x1d4/0x21c
> >
>
> + set -o errexit
> + set -o nounset
> + UTIL_SUFFIX=
> + [[ '' == '' ]]
Did you get a chance to look into this.
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2026-09-23 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 1:24 Srikar Dronamraju
2026-09-14 19:00 ` Josh Poimboeuf
2026-09-15 2:15 ` Srikar Dronamraju
2026-09-23 9:26 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arObLLalNd_fMi2u@linux.ibm.com \
--to=srikar@linux.ibm.com \
--cc=bjohannesmeyer@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®