mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf buildid-list: Fix empty output for AUX data
Date: Thu, 24 Sep 2026 19:42:48 +0200	[thread overview]
Message-ID: <arVhGILpes7fRK0b@x2> (raw)
In-Reply-To: <CAP-5=fWUZrANh69W=aADmSwhg-8ogFBheL+chOHAWbRuhijEew@mail.gmail.com>

On Tue, Sep 22, 2026 at 10:21:25PM -0700, Ian Rogers wrote:
> On Tue, Sep 22, 2026 at 7:47 AM James Clark <james.clark@linaro.org> wrote:
> >
> > perf record enables buildid_all for AUX trace because buildid-list does
> > not decode AUX data to identify hit DSOs. Historically those build IDs
> > were available in HEADER_BUILD_ID, and buildid-list disabled hit
> > filtering when HEADER_AUXTRACE was present.
> >
> > Build IDs are now carried by MMAP2 records by default and the build-ID
> > header is omitted. perf_session__list_build_ids() forces with_hits when
> > the header is absent so that it processes the event stream. That also
> > filters the result to DSOs referenced by ordinary samples. AUX data has
> > no such samples unless the trace is decoded, so every DSO is dropped and
> > perf archive reports that no build IDs were found.
> >
> > Process the event stream whenever the build-ID header is absent,
> > allowing MMAP2 build IDs to be read, but do not enable hit filtering for
> > AUX data, this ensures that all build-IDs are included for AUX data.
> >
> > Fixes: 6bd89ae7d147 ("perf record: Make sure to update build-ID cache")
> > Assisted-by: Codex:GPT-5.6-Sol
> > Signed-off-by: James Clark <james.clark@linaro.org>
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo

      reply	other threads:[~2026-09-24 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 14:47 James Clark
2026-09-23  5:21 ` Ian Rogers
2026-09-24 17:42   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arVhGILpes7fRK0b@x2 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®