From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: James Clark <james.clark@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] perf test: Improve shellcheck source directives
Date: Thu, 24 Sep 2026 19:50:42 +0200 [thread overview]
Message-ID: <arVi8iy821vO44tO@x2> (raw)
In-Reply-To: <arGXoU4idVCKb2cC@google.com>
On Mon, Sep 21, 2026 at 01:46:25PM -0700, Namhyung Kim wrote:
> On Mon, Sep 21, 2026 at 04:47:27PM +0100, James Clark wrote:
> > Confusingly two things turned out to be relevant to this. One is that -a
> > doesn't make shellcheck follow "external" paths, which these are treated
> > as. You need -x for that. Secondly, the source= directives don't cause
> > it to follow the path either, they just suppress a warning message about
> > dynamic paths in versions of shellcheck before 0.7.2. This warning can
> > be silenced with "source=/dev/null" and doesn't require any particular
> > path to be provided if -x isn't used.
> > James Clark (2):
> > perf test: Remove redundant shellcheck source paths
> > perf build: Follow sourced files when running shellcheck
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
prev parent reply other threads:[~2026-09-24 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:47 James Clark
2026-09-21 15:47 ` [PATCH 1/2] perf test: Remove redundant shellcheck source paths James Clark
2026-09-21 15:47 ` [PATCH 2/2] perf build: Follow sourced files when running shellcheck James Clark
2026-09-21 20:46 ` [PATCH 0/2] perf test: Improve shellcheck source directives Namhyung Kim
2026-09-24 17:50 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arVi8iy821vO44tO@x2 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®