Re: [PATCH v2] perf annotate: Fix NULL pointer dereference in loongarch_call__parse

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Tue, Sep 15, 2026 at 03:47:38PM -0700, Ian Rogers wrote:
> On Mon, Apr 27, 2026 at 8:53 PM WANG Rui <wangrui@loongson.cn> wrote:
> > On Thu, Apr 23, 2026 at 6:35 PM Jianping Liu <frankljpliu@gmail.com> wrote:
> > > Rather than aborting parse with -1 (which would clear dl->ins.ops and
> > > lose the is_call attribute, preventing the TUI from drawing branch
> > > arrows and navigating the call), follow the same pattern as the generic
> > > call__parse() in util/disasm.c: when the symbol name is absent, jump to
> > > the address-based symbol lookup so that ops->target.sym can still be
> > > resolved via maps__find_ams() using the already-parsed target address.
> > > This preserves is_call semantics and keeps TUI navigation working.

> > > - Link to v1: https://lore.kernel.org/all/20260423053102.3717015-1-frankljpliu@gmail.com/

> > > Fixes: 4ca0d340ce20 ("perf annotate: Fix instruction association and parsing for LoongArch")
> > > Signed-off-by: Jianping Liu <frankjpliu@tencent.com>
> > > Reviewed-by: Ming Wang <wangming01@loongson.cn>

> > Tested-by: WANG Rui <wangrui@loongson.cn>
 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo