mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Christian Melendez <chrismelnu@gmail.com>
Cc: acme@kernel.org, irogers@google.com, jolsa@kernel.org,
	peterz@infradead.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf stat: document task-clock/cpu-clock in TIMINGS
Date: Thu, 24 Sep 2026 15:23:57 -0700	[thread overview]
Message-ID: <arWi_dY4y15J2rqh@google.com> (raw)
In-Reply-To: <20260923135140.386033-1-chrismelnu@gmail.com>

Hello,

On Wed, Sep 23, 2026 at 03:51:40PM +0200, Christian Melendez wrote:
> task-clock/cpu-clock appear in perf stat's own example output but
> were never explained in perf-stat.txt, unlike time elapsed/user/sys.
> This came up unanswered on the list in 2013 and 2015 without docs
> ever being added.
> 
> Link: https://patch.msgid.link/CAP-5=fV0-yvc68BUSKoSajHjHY_A6COgbEJYiFxRg+G-8LeJhQ@mail.gmail.com
> Signed-off-by: Christian Melendez <chrismelnu@gmail.com>
> ---
>  tools/perf/Documentation/perf-stat.txt | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
> index f334aabdc809..c0d6c344f9eb 100644
> --- a/tools/perf/Documentation/perf-stat.txt
> +++ b/tools/perf/Documentation/perf-stat.txt
> @@ -621,6 +621,16 @@ user/system lands:
>  
>  Those times are the very same as displayed by the 'time' tool.
>  
> +We also display a clock-based timing metric that depends on the
> +target being monitored:
> +
> +        83723.452481      task-clock:u (msec)       #    1.004 CPUs utilized

I'm afraid task-clock and any other software events don't support
privilege filters or modifiers.  So task-clock:u would be same as
task-clock, but it can give a wrong idea that it only measured time
in userspace.

Maybe the kernel can reject ones with modifiers but then it would have
a compatibility issue. :(

So I think it's better to remove the ":u" modifier in the example
output.  Probably we need to change the perf not to add it to the
software events.

Thanks,
Namhyung

> +
> +For a single task, task-clock reports a clock count specific to that
> +task. When the target is a CPU or the whole system (-a or -C),
> +cpu-clock is reported instead. cpu-clock is a high-resolution per-CPU
> +timer. See perf_event_open(2) for more details.
> +
>  CSV FORMAT
>  ----------
>  
> @@ -671,4 +681,4 @@ that can be used for parsing.
>  
>  SEE ALSO
>  --------
> -linkperf:perf-top[1], linkperf:perf-list[1]
> +linkperf:perf-top[1], linkperf:perf-list[1], perf_event_open(2)
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2026-09-24 22:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 21:55 perf stat: worth documenting task-clock/cpu-clock in perf-stat.txt? Christian Melendez
2026-09-23  7:41 ` Ian Rogers
2026-09-23 13:51   ` [PATCH] perf stat: document task-clock/cpu-clock in TIMINGS Christian Melendez
2026-09-23 15:14     ` Ian Rogers
2026-09-24 17:38       ` Arnaldo Carvalho de Melo
2026-09-24 22:23     ` Namhyung Kim [this message]
2026-09-24 22:46       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arWi_dY4y15J2rqh@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=chrismelnu@gmail.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®