From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f13.google.com (mail-qk2-f13.google.com [74.125.230.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 394311DA0E1 for ; Fri, 25 Sep 2026 00:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.205 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790296508; cv=none; b=DUcFdYgClrVOzZcxL2ZaAOP9IDCBwP25XpFHQrgOlOMNnDapA/c82OwoIz3KgRsLXInqKQ5EkJcR3BsFgtDusOFDkfWxuaVVthZwY8LKtwz3PFzGB/EIcWXw5BAeVCXxBOsQTGw3mCkcss+QpbsHNRD5zzZ0Qgf2VWL0yywphvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790296508; c=relaxed/simple; bh=5Yn/V49OL4qwBUPSEZYOuA2XjrtAYM/2F6LNKtkgSDs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PTXSx0lHMnU2OtVlrGzJa+5ToBIBVdphb7Q96OlXmDSf/dIu4GW6mM0edYsFmxGtSuSFxVDLhk0zB3C6DRFmhrASIUqL9NFVx5YRFa9oOROsGFxsfpnN71TgDt1HXg2R+hT4040NCo8qperkPih0nS1qndu5YmYj7Zyle+QkCGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=WLD7tQHO; arc=none smtp.client-ip=74.125.230.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="WLD7tQHO" Received: by mail-qk2-f13.google.com with SMTP id d75a77b69052e-530c602630bso4907651cf.3 for ; Thu, 24 Sep 2026 17:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1790296505; x=1790901305; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hT0C0mvf6r5FuTfZclgfx4VcRqH28SXA1w/+lQNjyOc=; b=WLD7tQHOyBfqxqtDoY3qRt1kj7PPbcQjEO4xUXy/bAKwNG8fFRq7CW3rIzwdv2l55h K+I9GnM/kC738ny7I3M+oyw84ofe/t45Taj2BASl3+TMOlRkEXZ8oFb75YRwPqeyozMM 0VcGxz2f09l2Vi+BtfkHFmddylYue2zfedGPQmVULqKfBKkpDhF26YELoKspi0lW0UNi m679EVCoTx2xixvKNYxHZQWy1vyO/A8K3DfL/GwuZkvnDsK+M4T7sDetZiyjxFdWVz8+ YxAwF+BgM0mXXpqI19dI7oRGWMPD1wDfATG2pC6fJnEZnHYi8ybaacO5ZOPzfSEV7el6 7TqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790296505; x=1790901305; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hT0C0mvf6r5FuTfZclgfx4VcRqH28SXA1w/+lQNjyOc=; b=MQMMSriE4enrqu+ABRRFNRZBaAVzQ+gIsu8yAtQaMs3x1CW8kErw4OWCQUFeGglpDN jxT11Gem10zHx3VzLA8LTOBsIlp7tkyW5NHDA25NFSt/5aO79t0y8bfTby09nFcvoz5O kHGPOJXLDORFV4MK9pE2kngzw39C8G9f5NsXjrpibEy+lplQfA47Prd+UifJr1KSUs4/ M+6uXRKiGwpNA9vli04O2xsGUlSQia9y1YTMDsrdCvZCdTDtNAnxGG32dznKrwNjiJ69 arFSQSQbGZB2XF0UfC4UfXSRHEaOknYSErYBzsSp+IcVEY6oVEAuasLmIsK9XiQBWR4p fOeA== X-Forwarded-Encrypted: i=1; AKwUvByMcIx79qb2mqxWIKJDDWSsju/POJ5dXd6/NkW41yKC13R6ZR+/7ZQ7LyYgeil7OPpTdJaAhragNDjwmHk=@vger.kernel.org X-Gm-Message-State: AFuF++ldcHualhI+TQQuFVvPxXZRY+xRYYmqRbht5FzXvBW9MNNtsKN9 gu+/SuGhEfSKAWdr8g1fdyJ8QPNgYaSh2ADFbOUqL63kZz63RrxGCTlAwH92vp840aU= X-Gm-Gg: AYBFou23Ypg4s5GZDTP7aLgryYLmJvAgk9amcth4DTc9jGC6vPAjxxAA8A+/VhwN21p +8KUOGlMaL0KtYSUzjXTQxw/v32ADfNKpEUhPzpXTmNSQ2KAKnPajCDpEdx2sgIgG2zZKySitMg h91NWzgXKkL9Mg6k0x2w2DuusnZOkvBoFCTc3VhpVFScExRluYrJ0n/In7dE3t3+MVukA/cPCfP tV5LWuGESiNNzOB5/pOwY1xKGX712OCds7F9oiaOj54wAIL20Ky0mQxsa7g1UbNFfN13UUWEGSi /elmnjzC+RMXrKMOChM8KplepUj94MUEQWpiQvao2403Bw/3PAIbLHSOHj31n6xhx71FYp/Krvr tfpUGM2ApmtO1f6MEkFc7h9ECWMd8tkwuPt+yOCQ+HtAi28gspnNBRdFmmmQq2g66VYBv9RWQtH 7/8bqdFq0/q4HOieZTJyyCfJApYNo67YlKhxRcmfvKziw8iu1hfXCyensXpNYY3+bqB3GGM+HLQ 07dSuNJgdqQqZImqZ1jUKHWMnmXjyzAKUmZwGdh4lGdNLvEh2N6Y20= X-Received: by 2002:a05:6214:5910:b0:912:bd1:49f5 with SMTP id 6a1803df08f44-9142f681cf9mr18652786d6.10.1790296504108; Thu, 24 Sep 2026 17:35:04 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91430e87fa4sm5357886d6.41.2026.09.24.17.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 17:35:03 -0700 (PDT) Date: Thu, 24 Sep 2026 20:35:01 -0400 From: Gregory Price To: "David Hildenbrand (Arm)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, kas@kernel.org, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, ying.huang@linux.alibaba.com, apopple@nvidia.com, jannh@google.com, pfalcato@suse.de, hannes@cmpxchg.org, shy828301@gmail.com, raghavendra.kt@amd.com, stable@vger.kernel.org Subject: Re: [PATCH v3 3/7] sched/numa: scan read-only file mappings in tiering mode Message-ID: References: <20260922182928.2199090-1-gourry@gourry.net> <20260922182928.2199090-4-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Sep 24, 2026 at 10:53:56PM +0200, David Hildenbrand (Arm) wrote: > > + placement_scan &= numab_mode & NUMA_BALANCING_NORMAL; > > Do we have to update placement_scan at all? in the following commits this composes: placement_scan &= numab_mode & NUMA_BALANCING_NORMAL; if (scan_started) placement_scan &= vma->numab_state->placement_scan; else if (tiering) placement_scan &= placement_due; But i'll think about this when I update the function name. > > Can't we do: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 8a4687f67d82f..fc8862ee31442 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4121,6 +4121,7 @@ static void task_numa_work(struct callback_head *work) > { > const unsigned int numab_mode = READ_ONCE(sysctl_numa_balancing_mode); > const bool tiering = numab_mode & NUMA_BALANCING_MEMORY_TIERING; > + const bool balancing = numab_mode & NUMA_BALANCING_NORMAL; > unsigned long migrate, next_scan, now = jiffies; > struct task_struct *p = current; > struct mm_struct *mm = p->mm; > @@ -4313,9 +4314,8 @@ static void task_numa_work(struct callback_head *work) > continue; > } > > - placement_scan &= numab_mode & NUMA_BALANCING_NORMAL; > cp_flags = MM_CP_PROT_NUMA; > - if (!placement_scan) > + if (!placement_scan || !balancing) > cp_flags |= MM_CP_PROT_NUMA_PROMO_ONLY; > > do { > > (maybe I messed up my boolean algreba, it's late) > > -- > Cheers, > > David >