From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF66C36E47A; Fri, 25 Sep 2026 07:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790321096; cv=none; b=lYAG+T/4oWFVAzkeKMTjqhbEACqj2EBKK+K3C18MXoVFWQFqdbx+ZFf7n6Bseis3mPOi/Vv+eMV7xfmVuDE3PsN4+slfQWtngEOUrGNojtrLsN1h7433zT5uH8AiqowBE+jj1XDSCB6gfFx5Yws7UiQZ/7bbTAAECpfIuctJyPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790321096; c=relaxed/simple; bh=0VOHKEzRhehp0zEUuwNIJeuPoAxqqEaHLkE7NqM9JZA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MBtA4To/zX8ka0loPp6jwLLoGmreo/vMAMoceQpCc+6NahJrr/kfPztDLdMR7fWRLiLOYtUeirWx/lilsvhMIi0cgyXlDEF16NoZxVBCFYeup/I9QQ0a5C2kuEzExvgJ4Lq1ehmIueXcsfKDOvzM6mI83OZ8/4MBpPHgdQUZux0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T51PMqdt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T51PMqdt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E27C41F000FF; Fri, 25 Sep 2026 07:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790321094; bh=LXRP/1wipC9J8UX4qDqGkgwn+tmzgWEzq4b5o6Ax+9I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=T51PMqdtftu+im81DJxP4CPkokLbkFS53m9mcYvmL3K+t5ROMTQfep6P85iiVzFTP Tv5Gk1D9fgKhMg0irB7CeOYqC6CbbMKLhDpoWtPTfbdhKClF/ZEMZp5xbUTZwucyov LHIvzNBAwCCv8DA5u8bsMxabWRLCRLmDyWZ5VZej+6kJJiNSWcnVTZ6DuAjvwSV+cy 85gyATs9AMckS1R/ZsJqY7aLzbNXWAFc7zf8E6/lZGQ2/AJWAjpVfSV+TXA27bcJCw ImxTZG6nmhATEQkHCStlEFASUI92lCS/ERcrJu4JiZZXDCzpccuFNZCXtN+DRCSfIA KQbcugiYY/WGg== Date: Fri, 25 Sep 2026 08:24:47 +0100 From: "Lorenzo Stoakes (ARM)" To: Mikhail Gavrilov Cc: Andrew Morton , David Hildenbrand , Dave Hansen , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Vishal Moola , Ingo Molnar , Lu Baolu , Jason Gunthorpe , Steven Rostedt , x86@kernel.org, linux-mm@kvack.org, regressions@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm: don't schedule deferred kernel page table freeing while booting Message-ID: References: <20260925050647.86913-1-mikhail.v.gavrilov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260925050647.86913-1-mikhail.v.gavrilov@gmail.com> On Fri, Sep 25, 2026 at 10:06:47AM +0500, Mikhail Gavrilov wrote: > Booting with a boot-time function tracer and a filter, for example > > ftrace=function ftrace_filter=pud_free_pmd_page > > panics on 7.3-rc4 as soon as the tracer starts: > > [ 23.531178] Starting tracer 'function' > [ 23.675800] Oops: general protection fault, probably for non-canonical address 0xdffffc0000000038: 0000 [#1] SMP KASAN NOPTI > [ 23.819917] KASAN: null-ptr-deref in range [0x00000000000001c0-0x00000000000001c7] > [ 23.964025] CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 7.3.0-rc4-fe2ec83746e5-with-fixes-v2+ #195 PREEMPT(undef) > [ 24.252248] RIP: 0010:__queue_work+0xab/0xf00 > [ 25.981629] Call Trace: > [ 26.125727] > [ 26.413912] ? pagetable_free_kernel+0x20/0x120 > [ 26.990283] queue_work_on+0x97/0xf0 > [ 27.134382] __cpa_collapse_large_pages+0x501/0x6f0 > [ 27.566662] cpa_flush+0x394/0x620 > [ 27.998953] change_page_attr_set_clr+0x321/0x4a0 > [ 29.151729] set_memory_rox+0xa2/0xf0 > [ 29.584018] create_trampoline+0x431/0x6f0 > ... > [ 44.343347] Kernel panic - not syncing: Attempted to kill the idle task! > > The boot-time tracer is started from early_trace_init(), which runs > before workqueue_init_early(). Making its trampoline read-only splits a > large page, and CPA collapses it again right away. The split table has > been a kernel page table since commit 9e4a3ec3411b > ("x86/mm/pat: Allocate split page tables as kernel page tables"), so the > collapse frees it through pagetable_free_kernel(), which queues work on > system_percpu_wq - still NULL at that point. That commit is correct in > itself; it only lets CPA reach pagetable_free_kernel() before the > workqueue that function relies on exists. > > Keep putting the table on the list, but don't schedule the work while > the system is still booting. A core_initcall schedules it once to free > whatever was queued by then. > > Fixes: 9e4a3ec3411b ("x86/mm/pat: Allocate split page tables as kernel page tables") > Suggested-by: David Hildenbrand (Arm) > Suggested-by: Lorenzo Stoakes (ARM) > Cc: stable@vger.kernel.org > Signed-off-by: Mikhail Gavrilov LGTM so: Reviewed-by: Lorenzo Stoakes (ARM) > Link: https://lore.kernel.org/20260924064321.23787-1-mikhail.v.gavrilov@gmail.com > --- > v3: > - Schedule the work once from a core_initcall to free whatever was > queued during boot (Lorenzo Stoakes, Dave Hansen, David Hildenbrand). > late_initcall would work just as well; workqueues exist from > workqueue_init() on. > - Keep the fix in pagetable_free_kernel() rather than skipping the > collapse during boot (Mike Rapoport): that would only avoid this > caller, and any other early free would still need a workqueue. > v2: https://lore.kernel.org/20260924092307.22813-1-mikhail.v.gavrilov@gmail.com > v1: https://lore.kernel.org/20260924064321.23787-1-mikhail.v.gavrilov@gmail.com > > Tested on a Ryzen 9 7950X with a Radeon RX 7900 XTX (lockdep, KASAN), > 7.3-rc4 plus unrelated local changes, by booting with > > ftrace=function ftrace_filter=pud_free_pmd_page,pagetable_free_kernel,kernel_pgtable_work_func,kernel_pgtable_drain_early > > The boot that panicked without the fix completes, and the trace shows > kernel_pgtable_drain_early() and then kernel_pgtable_work_func() before > any other kernel page table is freed. > > mm/pgtable-generic.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c > index b91b1a98029c..cd227fc05d2d 100644 > --- a/mm/pgtable-generic.c > +++ b/mm/pgtable-generic.c > @@ -438,12 +438,30 @@ static void kernel_pgtable_work_func(struct work_struct *work) > __pagetable_free(pt); > } > > +static void schedule_kernel_pgtable_free(void) > +{ > + schedule_work(&kernel_pgtable_work.work); > +} > + > void pagetable_free_kernel(struct ptdesc *pt) > { > spin_lock(&kernel_pgtable_work.lock); > list_add(&pt->pt_list, &kernel_pgtable_work.list); > spin_unlock(&kernel_pgtable_work.lock); > > - schedule_work(&kernel_pgtable_work.work); > + /* > + * The workqueue may not exist yet while the system is booting. > + * kernel_pgtable_drain_early() schedules the work once it does. > + */ > + if (system_state != SYSTEM_BOOTING) > + schedule_kernel_pgtable_free(); > +} > + > +static int __init kernel_pgtable_drain_early(void) > +{ > + /* Free the kernel page tables queued while booting. */ > + schedule_kernel_pgtable_free(); > + return 0; > } > +core_initcall(kernel_pgtable_drain_early); > #endif > -- > 2.55.0 > -- Cheers, Lorenzo