mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Zhan Xusheng <zhanxusheng1024@gmail.com>,
	irogers@google.com, changbin.du@huawei.com,
	adrian.hunter@intel.com, jolsa@kernel.org, mingo@redhat.com,
	peterz@infradead.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, zhanxusheng@xiaomi.com
Subject: Re: [PATCH v3] perf symbols: Apply the symfs flat layout to the composed filename
Date: Fri, 25 Sep 2026 14:07:28 +0200	[thread overview]
Message-ID: <arZkAFwiXTbkwSdT@x2> (raw)
In-Reply-To: <arWkmNKRbzF2FhoA@google.com>

On Thu, Sep 24, 2026 at 03:30:48PM -0700, Namhyung Kim wrote:
> On Tue, Sep 22, 2026 at 09:19:52PM +0800, Zhan Xusheng wrote:
> > BUILDID_DEBUGINFO needs one more step: the build id cache splits the first
> > two characters of the build id off into a directory name, so the basename
> > of the hierarchy path is only part of the build id.  Name the flat file
> > after the whole build id.
> > 
> > dso__disassemble_filename() passes a path from perf's own build id cache
> > rather than one on the profiled system, and every entry there is named
> > "elf" or "debug".  Use path__join() so the layout does not apply.
> > 
> > With --symfs /s,flat the lookups are now /s/libc.so.6, /s/libc.so.6.debug,
> > /s/sleep and /s/<build id>.debug.  hierarchy is unchanged.
> > 
> > Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> 
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo

      reply	other threads:[~2026-09-25 12:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 13:19 Zhan Xusheng
2026-09-24 22:30 ` Namhyung Kim
2026-09-25 12:07   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arZkAFwiXTbkwSdT@x2 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=changbin.du@huawei.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=zhanxusheng1024@gmail.com \
    --cc=zhanxusheng@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®