mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Delton Ding <dsh0416@gmail.com>
Cc: f13208471983@163.com, linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: crb: handle ACPI NVS memory region overlap
Date: Fri, 25 Sep 2026 17:24:58 +0300	[thread overview]
Message-ID: <araEOkjz1f_vnl3A@kernel.org> (raw)
In-Reply-To: <CA+mXNo2bBZg69RkKYauV_+K5zp=1kuHm1xLPwD6_ihZ_MzL0SQ@mail.gmail.com>

On Sun, Sep 20, 2026 at 02:33:12PM +0800, Delton Ding wrote:
> Hi Jarkko and MicroFish,
> 
> I'm following up on this discussion:
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2652132.html
> 
> I would like to add a Fujitsu/Intel platform with what appears to be a
> related NVS resource reservation failure. I have not tested the proposed
> patch; this is an additional hardware report.
> 
> Hardware and software:
> 
>   System: FUJITSU FMVU14003
>   Board: FJNB2B5
>   CPU: Intel Core i5-7300U (family 6, model 142, stepping 9)
>   BIOS: Version 1.33, 11/25/2025
>   OS: NixOS 26.05
>   Running kernel: 7.2.5 (NixOS build)
>   /proc/sys/kernel/tainted: 0
> 
> On this machine, the TPM2 table specifies StartMethod 2 (ACPI Start).
> The control area, rather than the MMIO range reported by _CRS, lies
> inside ACPI NVS:
> 
>   TPM2 table (length 52, revision 3, checksum valid):
>     ControlAddress: 0x000000008ff6e000
>     StartMethod:    2
> 
>   Relevant /proc/iomem entries:
>     8d77f000-8ff7efff : ACPI Non-volatile Storage
>     fed40000-fed44fff : MSFT0101:00
> 
>   The TPM SSDT declares _CRS with base 0xfed40000 and length 0x5000.
>   It also contains:
> 
>     OperationRegion (TPMR, SystemMemory, 0xFED40000, 0x5000)
>     OperationRegion (TNVS, SystemMemory, 0x8FF6F000, 0x27)
>     OperationRegion (CONA, SystemMemory, 0x8FF6E000, 0x30)
> 
> The kernel reports:
> 
>   tpm_crb_acpi MSFT0101:00: error -EBUSY: can't request region for
> resource [mem 0x8ff6e000-0x8ff6e02f]
>   tpm_crb_acpi MSFT0101:00: probe with driver tpm_crb_acpi failed with error -16
>   ima: No TPM chip found, activating TPM-bypass!
> 
> Neither /dev/tpm0 nor /dev/tpmrm0 exists, and both /sys/class/tpm and
> /sys/class/tpmrm are empty. The ACPI device has status 15 and an existing
> platform physical_node, so platform device creation itself succeeded.
> 
> Based on the ACPI tables and source inspection, this appears to reach the
> iores == NULL path in crb_map_res() when crb_map_io() first maps the
> 48-byte control area. That area lies outside _CRS but within the NVS
> reservation. This is an inference from the tables and error range;
> I have not instrumented the driver to trace the call path.
> 
> Earlier boot logs show the same error and address on BIOS 1.10, 1.30
> with kernel 7.2.6. I do not have a known-good Linux kernel on this machine,
> so I am not reporting this as a confirmed regression. The TPM works in
> Windows on the same machine; its TPM firmware has also been updated.
> The vendor of the TPM is infineon, but the exact TPM firmware revision
> has not been collected here.
> 
> The missing devices cause systemd 260.2 to wait 90 seconds in the initrd
> and another 90 seconds after switching to the real root. We have prepared
> systemd.tpm2_wait=0 as a local workaround for the boot delay; it does not
> restore the TPM device.
> 
> Does this look like another instance of the NVS mapping issue, and is
> there a preferred revised patch or targeted diagnostic for this ACPI
> StartMethod 2 layout? I can provide the raw TPM2 table and TPM SSDT,
> including its disassembly, if useful.
> 
> Best Regards,
> Delton Ding

Yes it does.

I need to revisit this properly. Thanks for reminding.

Br, Jarkko

  reply	other threads:[~2026-09-25 14:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  6:33 Delton Ding
2026-09-25 14:24 ` Jarkko Sakkinen [this message]
2026-09-25 14:42   ` Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2026-08-27  3:55 microfish
2026-08-28  2:04 ` Jarkko Sakkinen
2026-08-28 11:11   ` MicroFish
2026-09-01 12:57     ` Jarkko Sakkinen
2026-09-01 14:35       ` Jarkko Sakkinen
2026-09-25 14:42 ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=araEOkjz1f_vnl3A@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dsh0416@gmail.com \
    --cc=f13208471983@163.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®