From: Frank Li <Frank.li@oss.nxp.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
pierluigi.p@variscite.com,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Joseph Guo <qijian.guo@nxp.com>,
Josua Mayer <josua@solid-run.com>,
Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
Mehmet Fide <mehmet.fide@screeningeagle.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Markus Niebel <Markus.Niebel@ew.tq-group.com>,
Maud Spierings <maudspierings@gocontroll.com>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Stefan Eichenberger <eichest@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 04/11] ARM: dts: imx6ul: Add Variscite audio codec files
Date: Fri, 25 Sep 2026 09:58:44 -0500 [thread overview]
Message-ID: <araMJFirhP86Dcb6@SMW015318> (raw)
In-Reply-To: <ef56f98137eb9d1e0af3aa1b801186d829dba521.1790344389.git.stefano.r@variscite.com>
On Fri, Sep 25, 2026 at 04:02:21PM +0200, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
>
> Add separate DTSI files for the WM8904 and WM8731 audio options on
> VAR-SOM-6UL and DART-6UL modules.
>
> Put each codec node, the SAI2 setup and its pinctrl in the selected
> audio DTSI. This makes the WM8904 option explicit instead of placing
> it in the shared module base.
>
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
> ---
> .../imx/imx6ul-imx6ull-var-dart-wm8731.dtsi | 71 +++++++++++++++
> .../imx/imx6ul-imx6ull-var-dart-wm8904.dtsi | 88 +++++++++++++++++++
> .../imx/imx6ul-imx6ull-var-som-wm8731.dtsi | 71 +++++++++++++++
> .../imx/imx6ul-imx6ull-var-som-wm8904.dtsi | 85 ++++++++++++++++++
what's difference between imx6ul-imx6ull-var-som-wm8904.dtsi and
imx6ul-imx6ull-var-dart-wm8904.dtsi?
Frank
> 4 files changed, 315 insertions(+)
> create mode 100644 arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8731.dtsi
> create mode 100644 arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8904.dtsi
> create mode 100644 arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8731.dtsi
> create mode 100644 arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8904.dtsi
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8731.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8731.dtsi
> new file mode 100644
> index 000000000000..7d74fc3b7014
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8731.dtsi
> @@ -0,0 +1,71 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/ {
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,bitclock-master = <&sound_master>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&sound_master>;
> + simple-audio-card,name = "wm8731audio";
> + simple-audio-card,routing =
> + "Headphone Jack", "RHPOUT",
> + "Headphone Jack", "LHPOUT",
> + "LLINEIN", "Line Jack",
> + "RLINEIN", "Line Jack",
> + "MICIN", "Mic Bias",
> + "Mic Bias", "Mic Jack";
> + simple-audio-card,widgets =
> + "Headphone", "Headphone Jack",
> + "Line", "Line Jack",
> + "Microphone", "Mic Jack";
> +
> + sound_master: simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&codec>;
> + system-clock-frequency = <12288000>;
> + };
> + };
> +};
> +
> +&i2c2 {
> + codec: audio-codec@1a {
> + compatible = "wlf,wm8731";
> + reg = <0x1a>;
> + #sound-dai-cells = <0>;
> + clocks = <&clks IMX6UL_CLK_SAI2>;
> + clock-names = "mclk";
> + AVDD-supply = <®_3p3v>;
> + DBVDD-supply = <®_3p3v>;
> + DCVDD-supply = <®_3p3v>;
> + HPVDD-supply = <®_3p3v>;
> + };
> +};
> +
> +&sai2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sai2>;
> + assigned-clocks = <&clks IMX6UL_CLK_SAI2_SEL>,
> + <&clks IMX6UL_CLK_SAI2>;
> + assigned-clock-parents = <&clks IMX6UL_CLK_PLL4_AUDIO_DIV>;
> + assigned-clock-rates = <0>, <12288000>;
> + fsl,sai-mclk-direction-output;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_sai2: sai2-grp {
> + fsl,pins = <
> + MX6UL_PAD_JTAG_TDI__SAI2_TX_BCLK 0x17088
> + MX6UL_PAD_JTAG_TDO__SAI2_TX_SYNC 0x17088
> + MX6UL_PAD_JTAG_TRST_B__SAI2_TX_DATA 0x11088
> + MX6UL_PAD_JTAG_TCK__SAI2_RX_DATA 0x11088
> + MX6UL_PAD_JTAG_TMS__SAI2_MCLK 0x17088
> + >;
> + };
> +};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8904.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8904.dtsi
> new file mode 100644
> index 000000000000..1e1ff8c6d7b5
> --- /dev/null
/809> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-wm8904.dtsi
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/ {
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,bitclock-master = <&sound_master>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&sound_master>;
> + simple-audio-card,name = "wm8904audio";
> + simple-audio-card,routing =
> + "Headphone Jack", "HPOUTL",
> + "Headphone Jack", "HPOUTR",
> + "IN1L", "Line In Jack",
> + "IN1R", "Line In Jack",
> + "IN2L", "Microphone Jack",
> + "IN2R", "Microphone Jack",
> + "Microphone Jack", "MICBIAS";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Headphone", "Headphone Jack",
> + "Line", "Line In Jack";
> + simple-audio-card,mclk-fs = <256>;
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + };
> +
> + sound_master: simple-audio-card,codec {
> + sound-dai = <&codec>;
> + };
> + };
> +};
> +
> +&i2c2 {
> + codec: audio-codec@1a {
> + compatible = "wlf,wm8904";
> + reg = <0x1a>;
> + #sound-dai-cells = <0>;
> + clocks = <&clks IMX6UL_CLK_SAI2>;
> + clock-names = "mclk";
> + AVDD-supply = <®_3p3v>;
> + CPVDD-supply = <®_3p3v>;
> + DBVDD-supply = <®_3p3v>;
> + DCVDD-supply = <®_3p3v>;
> + MICVDD-supply = <®_3p3v>;
> + wlf,drc-cfg-names = "default", "peaklimiter", "tradition",
> + "soft", "music";
> + /*
> + * Config registers per name, respectively:
> + * KNEE_IP = 0, KNEE_OP = 0, HI_COMP = 1, LO_COMP = 1
> + * KNEE_IP = -24, KNEE_OP = -6, HI_COMP = 1/4, LO_COMP = 1
> + * KNEE_IP = -42, KNEE_OP = -3, HI_COMP = 0, LO_COMP = 1
> + * KNEE_IP = -45, KNEE_OP = -9, HI_COMP = 1/8, LO_COMP = 1
> + * KNEE_IP = -30, KNEE_OP = -10.5, HI_COMP = 1/4, LO_COMP = 1
> + */
> + wlf,drc-cfg-regs = /bits/ 16 <0x01af 0x3248 0x0000 0x0000>,
> + /bits/ 16 <0x04af 0x324b 0x0010 0x0408>,
> + /bits/ 16 <0x04af 0x324b 0x0028 0x0704>,
> + /bits/ 16 <0x04af 0x324b 0x0018 0x078c>,
> + /bits/ 16 <0x04af 0x324b 0x0010 0x050e>;
> + };
> +};
> +
> +&sai2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sai2>;
> + assigned-clocks = <&clks IMX6UL_CLK_SAI2_SEL>,
> + <&clks IMX6UL_CLK_SAI2>;
> + assigned-clock-parents = <&clks IMX6UL_CLK_PLL4_AUDIO_DIV>;
> + assigned-clock-rates = <0>, <11565177>;
> + fsl,sai-mclk-direction-output;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_sai2: sai2-grp {
> + fsl,pins = <
> + MX6UL_PAD_JTAG_TDI__SAI2_TX_BCLK 0x17088
> + MX6UL_PAD_JTAG_TDO__SAI2_TX_SYNC 0x17088
> + MX6UL_PAD_JTAG_TRST_B__SAI2_TX_DATA 0x11088
> + MX6UL_PAD_JTAG_TCK__SAI2_RX_DATA 0x11088
> + MX6UL_PAD_JTAG_TMS__SAI2_MCLK 0x17088
> + >;
> + };
> +};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8731.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8731.dtsi
> new file mode 100644
> index 000000000000..7d74fc3b7014
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8731.dtsi
> @@ -0,0 +1,71 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/ {
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,bitclock-master = <&sound_master>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&sound_master>;
> + simple-audio-card,name = "wm8731audio";
> + simple-audio-card,routing =
> + "Headphone Jack", "RHPOUT",
> + "Headphone Jack", "LHPOUT",
> + "LLINEIN", "Line Jack",
> + "RLINEIN", "Line Jack",
> + "MICIN", "Mic Bias",
> + "Mic Bias", "Mic Jack";
> + simple-audio-card,widgets =
> + "Headphone", "Headphone Jack",
> + "Line", "Line Jack",
> + "Microphone", "Mic Jack";
> +
> + sound_master: simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&codec>;
> + system-clock-frequency = <12288000>;
> + };
> + };
> +};
> +
> +&i2c2 {
> + codec: audio-codec@1a {
> + compatible = "wlf,wm8731";
> + reg = <0x1a>;
> + #sound-dai-cells = <0>;
> + clocks = <&clks IMX6UL_CLK_SAI2>;
> + clock-names = "mclk";
> + AVDD-supply = <®_3p3v>;
> + DBVDD-supply = <®_3p3v>;
> + DCVDD-supply = <®_3p3v>;
> + HPVDD-supply = <®_3p3v>;
> + };
> +};
> +
> +&sai2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sai2>;
> + assigned-clocks = <&clks IMX6UL_CLK_SAI2_SEL>,
> + <&clks IMX6UL_CLK_SAI2>;
> + assigned-clock-parents = <&clks IMX6UL_CLK_PLL4_AUDIO_DIV>;
> + assigned-clock-rates = <0>, <12288000>;
> + fsl,sai-mclk-direction-output;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_sai2: sai2-grp {
> + fsl,pins = <
> + MX6UL_PAD_JTAG_TDI__SAI2_TX_BCLK 0x17088
> + MX6UL_PAD_JTAG_TDO__SAI2_TX_SYNC 0x17088
> + MX6UL_PAD_JTAG_TRST_B__SAI2_TX_DATA 0x11088
> + MX6UL_PAD_JTAG_TCK__SAI2_RX_DATA 0x11088
> + MX6UL_PAD_JTAG_TMS__SAI2_MCLK 0x17088
> + >;
> + };
> +};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8904.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8904.dtsi
> new file mode 100644
> index 000000000000..72a73011af6f
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-wm8904.dtsi
> @@ -0,0 +1,85 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/ {
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,bitclock-master = <&sound_master>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&sound_master>;
> + simple-audio-card,name = "wm8904audio";
> + simple-audio-card,routing =
> + "Headphone Jack", "HPOUTL",
> + "Headphone Jack", "HPOUTR",
> + "IN1L", "Line In Jack",
> + "IN1R", "Line In Jack";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Headphone", "Headphone Jack",
> + "Line", "Line In Jack";
> + simple-audio-card,mclk-fs = <256>;
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + };
> +
> + sound_master: simple-audio-card,codec {
> + sound-dai = <&codec>;
> + };
> + };
> +};
> +
> +&i2c2 {
> + codec: audio-codec@1a {
> + compatible = "wlf,wm8904";
> + reg = <0x1a>;
> + #sound-dai-cells = <0>;
> + clocks = <&clks IMX6UL_CLK_SAI2>;
> + clock-names = "mclk";
> + AVDD-supply = <®_3p3v>;
> + CPVDD-supply = <®_3p3v>;
> + DBVDD-supply = <®_3p3v>;
> + DCVDD-supply = <®_3p3v>;
> + MICVDD-supply = <®_3p3v>;
> + wlf,drc-cfg-names = "default", "peaklimiter", "tradition",
> + "soft", "music";
> + /*
> + * Config registers per name, respectively:
> + * KNEE_IP = 0, KNEE_OP = 0, HI_COMP = 1, LO_COMP = 1
> + * KNEE_IP = -24, KNEE_OP = -6, HI_COMP = 1/4, LO_COMP = 1
> + * KNEE_IP = -42, KNEE_OP = -3, HI_COMP = 0, LO_COMP = 1
> + * KNEE_IP = -45, KNEE_OP = -9, HI_COMP = 1/8, LO_COMP = 1
> + * KNEE_IP = -30, KNEE_OP = -10.5, HI_COMP = 1/4, LO_COMP = 1
> + */
> + wlf,drc-cfg-regs = /bits/ 16 <0x01af 0x3248 0x0000 0x0000>,
> + /bits/ 16 <0x04af 0x324b 0x0010 0x0408>,
> + /bits/ 16 <0x04af 0x324b 0x0028 0x0704>,
> + /bits/ 16 <0x04af 0x324b 0x0018 0x078c>,
> + /bits/ 16 <0x04af 0x324b 0x0010 0x050e>;
> + };
> +};
> +
> +&sai2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sai2>;
> + assigned-clocks = <&clks IMX6UL_CLK_SAI2_SEL>,
> + <&clks IMX6UL_CLK_SAI2>;
> + assigned-clock-parents = <&clks IMX6UL_CLK_PLL4_AUDIO_DIV>;
> + assigned-clock-rates = <0>, <11565177>;
> + fsl,sai-mclk-direction-output;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_sai2: sai2-grp {
> + fsl,pins = <
> + MX6UL_PAD_JTAG_TDI__SAI2_TX_BCLK 0x17088
> + MX6UL_PAD_JTAG_TDO__SAI2_TX_SYNC 0x17088
> + MX6UL_PAD_JTAG_TRST_B__SAI2_TX_DATA 0x11088
> + MX6UL_PAD_JTAG_TCK__SAI2_RX_DATA 0x11088
> + MX6UL_PAD_JTAG_TMS__SAI2_MCLK 0x17088
> + >;
> + };
> +};
> --
> 2.47.3
>
>
next prev parent reply other threads:[~2026-09-25 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 14:02 [PATCH v1 00/11] ARM: dts: imx6ul: Add Variscite VAR-SOM-6UL and DART-6UL Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 01/11] dt-bindings: arm: fsl: Document Variscite i.MX6UL boards Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 02/11] dt-bindings: net: micrel: Fix RMII clock select property type Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 03/11] ARM: dts: imx6ul: Add Variscite SoM and DART base files Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 04/11] ARM: dts: imx6ul: Add Variscite audio codec files Stefano Radaelli
2026-09-25 14:58 ` Frank Li [this message]
2026-09-25 15:57 ` Stefano Radaelli
2026-09-25 16:42 ` Frank Li
2026-09-25 14:02 ` [PATCH v1 05/11] ARM: dts: imx6ul: Add Variscite storage and wireless files Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 06/11] ARM: dts: imx6ul: Add Variscite carrier board files Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 07/11] ARM: dts: imx6ul: Reuse Variscite DTSI files for Concerto Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 08/11] ARM: dts: imx6ul: Add Variscite i.MX6UL board variants Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 09/11] ARM: dts: imx6ull: Add Variscite i.MX6ULL " Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 10/11] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ " Stefano Radaelli
2026-09-25 14:02 ` [PATCH v1 11/11] ARM: dts: imx6ul: Enable Variscite i.MX6UL board DTBs Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=araMJFirhP86Dcb6@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=ernest.vanhoecke@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hvilleneuve@dimonoff.com \
--cc=imx@lists.linux.dev \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maudspierings@gocontroll.com \
--cc=mehmet.fide@screeningeagle.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pierluigi.p@variscite.com \
--cc=qijian.guo@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefano.r@variscite.com \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®