From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07E974D0CD6 for ; Fri, 25 Sep 2026 15:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790350517; cv=none; b=DSU0gbLMtnI5uZzlkjo1Ee0Xq+37MPhAyUVDiQOpKY7+pozbRK8DsjgjWRnCwioByIKTppjTqMJGbZN+6WfRmdUpnIAgmkdwuvFUnsSTYWdukqOJztFP4jyCzVubc6idjM3GuefiFjqdlRDJakjyUsk5c2n0QWMkxkXAPfHoTiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790350517; c=relaxed/simple; bh=JaK3xKbkE7wgtjaM89B5KJpD0MqI4l82LuAW/Bbj87w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vAoacaltm+FEPhiFAwFEEsZH/pXFmq3idO5ZlasY/YR9syeg6f3Un1LmgcNqO/lsrtN730n2IGA6aHxuZF8M0idCR6Rg8eRMXQjcJk3OGrAANf0ZQAbRN7lpetBlkmqcC0rc0Zi2+1/sQ917HTfT0pFkzouF9V25pvgi4SOXau8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IdiLf6Ps; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b9PrFBxA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IdiLf6Ps"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b9PrFBxA" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68PEAa1h600037 for ; Fri, 25 Sep 2026 15:35:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=iLVqjTd3vlJrX7TuKVolKFoP zagTa2lbaJ2iN6D9p1w=; b=IdiLf6PsV6W9P9nqrPW6yS7IfgFot2tki0Bd+sZK k0DVKOgu+wPaHKoQcPbVZSTQ4CFnv3eaVNZdresMoVzq3+CvnH/Djs363T8EQTeg BT8pRD/UPV40EBAvt+VXjlhoflqt7OP8ZrmkpAL1R7BO3+y0YgufP0BBTGn7gPBe QehtM9mIr3mUvWvBMCUx6wzigpxIrXOfX6Hss5qo5YJQN6hcY4BKB8s0RmKsjbYh Kq5YAlloBernxsWP/or4VTr81KHvXg90nIcih9uXr/Ar4GczmyO0REaYngZI1NsS e9f+WMyRnrlNZ0OzMszXaKjax+kbUSAtqKGL61E7u2jGzg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gwjpvsy5f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 25 Sep 2026 15:35:13 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-880e099bba5so306209b3a.1 for ; Fri, 25 Sep 2026 08:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790350512; x=1790955312; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iLVqjTd3vlJrX7TuKVolKFoPzagTa2lbaJ2iN6D9p1w=; b=b9PrFBxAEreQhngEM9eZiNk0rr6nmPzQSmwAEFmSJGeLHGS95HkI8CkxbyMXfuS+Sp LTNuiU+Kgq+b1+4KBx+Tf1undKd2G8Nf7nD3UNfueRFyGLCrg1cQh9XTVXC+5KfOI56f DWLqgRVsCuPAAm2RwSlSyjxD3BuM9WhuVUHvT4GTRBmGzMM0V5mpDxoJJvcXoxycwWW8 kNEejLnXjEY+zRCmzfqp3KViE+cJ9+MKhDVapzt0Qx7Wj15C1KBD+WF7BKvUMqh0EXJz j+zjVLWxQwxbwqDpo46EdZ0GznQ1/SgAdIAPkYa2Q458wCpD/PPenHbPtMTi0o3FOWig UA2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790350512; x=1790955312; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iLVqjTd3vlJrX7TuKVolKFoPzagTa2lbaJ2iN6D9p1w=; b=DOAE33SDvvhh8X4XuFlljZUEkQXTrw855VZyVAoqyz1f2iCOtyjBXFbzvMRHwA5MG/ Nkxes5uKUKufuk6itbClGoh2YiJmDjH2anjeD9caRrviIOTWS4OucD+30TFGBTwK5UBp zQBBr/QKNojvRM+EPrmJw5Z14OuOWLkwIe5pyfTDbpX3MdD8yRUMdFymr9gmNhXMnWDz jF/GOhlzkjzXfXZTfSJ9JGM9wC/vZm65Z5jDUvE1SWwvlroBEEdK4eQUG24Q5Aui1zVn Rd9ANR+6w/oK3UXgFLbS4eCBkLCsc9hTFo5aK3U4O347wVYOk77E1WEBw2Pq1o7r3DI7 VSgg== X-Forwarded-Encrypted: i=1; AKwUvBwN+x2DlOfn4Vvos+zMPabmTEsUOe62NFvjooAy19w0fvm4AJBnm+uc67jtw+ljHkE+fER4MxlLWL2gcOI=@vger.kernel.org X-Gm-Message-State: AFuF++nsheaejknAv8AZAwdLJrvmmzKR/TLlMLmK5Utecx320USccGZu wwkK9pBr8jAWHiSRN3zoYK+v7dBGXOiy8InDC7cHE+p6T3eMNw6Ocj6QEKV0r0N4d0zwyC2qNAp mKRuM88hFHWAOy8bdT5IH1xxxxSu2JqseKMF6+zioLlygl5yisJYq4pOHAKqPPjgXa5w= X-Gm-Gg: AYBFou1KpcgJObg03rndAC5MBww0CXgy926Scce7fd1ol/lwZy/bljbJenCWBRfySry MLibaNboYXw54lZn7v5lR1DoU9JMke9Wil6US/k93dfJPJkiBnmbDXqkkMHxUExu1cTqXMz0grR XwgOUgzeg4SCs3N9Tw0DxfUMPsE1KzBVB+MaIc+T/lJWXa5tiV7GiI3J4df8sn44rS3gMHHLmP9 UAz6h+Voynb8Kggabxw45t8b3nv5efxNlo8He4r0he/T3p/O4AHkq8Yi6zPm3lMCu3jEq4LX3o4 kmKmhhmz+Sb7IygJdtrvOVP3jCuoITMG/wggg6PfMSUjAm7xxHCbwcPEPhUlXWI87taoDWvSYkr Ci23WtAxArlPEAjijaT4nwOK4M1FbBRNrffjtUHg2Jw== X-Received: by 2002:a05:6a00:3385:b0:851:b03a:fcb with SMTP id d2e1a72fcca58-88029fb84admr1967822b3a.14.1790350512052; Fri, 25 Sep 2026 08:35:12 -0700 (PDT) X-Received: by 2002:a05:6a00:3385:b0:851:b03a:fcb with SMTP id d2e1a72fcca58-88029fb84admr1967806b3a.14.1790350511480; Fri, 25 Sep 2026 08:35:11 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-87fea884749sm1325581b3a.27.2026.09.25.08.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 08:35:10 -0700 (PDT) Date: Fri, 25 Sep 2026 23:35:03 +0800 From: Shawn Guo To: Abel Vesa Cc: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Taniya Das , Jagadeesh Kona , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: dts: qcom: glymur: Add videocc sleep clock Message-ID: References: <20260924161152.1162301-1-shengchao.guo@oss.qualcomm.com> <20260924161152.1162301-3-shengchao.guo@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: w0ULGiks-NBDmcmCTSEwfZxti0lXhEym X-Proofpoint-ORIG-GUID: w0ULGiks-NBDmcmCTSEwfZxti0lXhEym X-Authority-Analysis: v=2.4 cv=aLBlOr9m c=1 sm=1 tr=0 ts=6ab694b1 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=XM2o5SXsTojDuVAecT4A:9 a=CjuIK1q_8ugA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI1MDA2MiBTYWx0ZWRfXwf4LBYZDLaIP YcMHc0ZskKyP8gtKIQj7q+fZm+6+lAje4t2K2hhxjFUyZqkbWCQT6fdI++uKPxEUV+RHYVhZOF8 xpOSLpbiYs7AhGyYb/F3KERqa/bqVBA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI1MDA2MiBTYWx0ZWRfX/6lwalD5kqtz C2DmDl46KORt+iZ/ZBdM4AwfdZS1l1a3uQvdaRT8UIub2iUTpyYBE8dut555huoKDUxpaOuGNwY F8Hhzkz5S8L9I287uhfUbukrMIYom8hwx4xRKevIkgrN/8stS26LWwGKniGc/WxrRLVNde3//lk a/weEKTzLu9+DkqBs4zQJeNZH/fLYNzr0QTKlezbnIZeuo+0duoRMO5eqIDN9+DsIfgkDVSFCKq JCDP36bFN0ggslHD9H7l6VoY5QOZxAXwGo2lZcnUNvvEBL0ONVt/fW27cp5sgCoLYMzc9U/O0Ij Hj6MF+nUoWSO9R8B+EcnAr2bkk7MowVaJX8Pd7k6wptEeh/WKv4poKGJL4ekLuSelw12iY3BEi8 4eIIod1qMqaVmQ6IOMXfqXSfTCjppTxwOna7/uGWnnMW73Kx3mZSJw/UJDsxnd413HuUL213ImV xG4RJ1G2uLzNPWNgg/w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-25_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609250062 On Fri, Sep 25, 2026 at 12:48:07PM +0300, Abel Vesa wrote: > On 26-09-25 00:11:51, Shawn Guo wrote: > > The videocc node supplies only the two XO inputs. videocc-glymur.c > > expects a third input, DT_SLEEP_CLK, and uses it as the parent of > > video_cc_sleep_clk_src, so that RCG cannot resolve its parent and ends > > up as an orphan clock: any clk_set_rate() on it fails, and it shows up > > parentless in /sys/kernel/debug/clk/clk_summary. > > > > Nothing is broken at runtime today because VIDEO_CC_SLEEP_CLK (0x8138) > > is listed in video_cc_glymur_critical_cbcrs and is therefore force > > enabled through regmap, bypassing the clock framework; the sleep source > > simply keeps whatever rate the bootloader left. The orphan still blocks > > any future rate management of the video sleep path. > > > > Pass the board sleep clock as the third input. The sibling evacc node > > on the same SoC already does this. > > Same question as on the 3rd patch. This patch doesn't drop GCC_VIDEO_AHB_CLK or any videocc input clock like 3rd patch but only adding the board sleep clock as the third input. So it shouldn't break videocc either. It would nice if you can give it a test on your X2 laptop though :) Shawn