mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@nvidia.com>
To: shashank <jain.sm@gmail.com>
Cc: Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] bitmap: fix three parsing bugs in bitmap_parse() and bitmap_parselist()
Date: Fri, 25 Sep 2026 13:05:06 -0400	[thread overview]
Message-ID: <arapwjg4cp25e3br@yury> (raw)
In-Reply-To: <20260925102307.49513-1-jain.sm@gmail.com>

On Fri, Sep 25, 2026 at 03:53:01PM +0530, shashank wrote:
> This series fixes three cases where the bitmap string parsers accept
> input they are documented to reject, or produce a different mask than
> the one requested.  Each fix is followed by a patch adding the failing
> cases to lib/test_bitmap.c.
> 
>  1-2: bitmap_parse() treats a non-hex character directly before a chunk
>       of exactly eight hex digits as a separator, so "x12345678" and
>       "0x0000000f" are accepted while "0xf" is rejected.  This is a
>       regression from the bitmap_parse() rework; the old __bitmap_parse()
>       rejected all of them.
> 
>  3-4: bitmap_parselist() does not check for the end of the region after
>       the group size of a "range:used/group" region, so since N and
>       all became valid region starts, "0-7:1/2N" or "0-7:1/2all" are
>       silently parsed as two regions.
> 
>  5-6: bitmap_parselist() walks a "range:used/group" region with an
>       unsigned int that wraps around when the group size is close to
>       UINT_MAX, setting bits below the requested range.  This needs an
>       absurd group size and never writes out of bounds.
> 
> With the series applied, test_bitmap reports "all 391544 tests passed"
> (UML, x86_64).  The three fixes are independent and can be applied in
> any order.

That looks reasonable, but please resend the series with your full
real name, and also specify the version of LLM you've used to prepare
the series. I'm uncomfortable taking anonymous commitments.
 
 Thanks,
 Yury

  parent reply	other threads:[~2026-09-25 17:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 10:23 shashank
2026-09-25 10:23 ` [PATCH 1/6] bitmap: bitmap_parse(): reject non-hex character before 8 digits shashank
2026-09-25 10:23 ` [PATCH 2/6] bitmap: test bitmap_parse() with an illegal character before 8 hex digits shashank
2026-09-25 10:23 ` [PATCH 3/6] bitmap: bitmap_parselist(): reject trailing characters after group size shashank
2026-09-25 10:23 ` [PATCH 4/6] bitmap: test bitmap_parselist() with text after the " shashank
2026-09-25 10:23 ` [PATCH 5/6] bitmap: bitmap_parselist(): don't wrap around on a huge " shashank
2026-09-25 10:23 ` [PATCH 6/6] bitmap: test bitmap_parselist() with a group size close to UINT_MAX shashank
2026-09-25 17:05 ` Yury Norov [this message]
2026-09-25 20:39   ` [PATCH 0/6] bitmap: fix three parsing bugs in bitmap_parse() and bitmap_parselist() Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arapwjg4cp25e3br@yury \
    --to=ynorov@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=jain.sm@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®