Re: [PATCH] MIPS: remove unused setup_profiling_timer function

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Thu, Aug 20, 2026 at 02:49:04PM +0200, Anthony Iliopoulos wrote:
> setup_profiling_timer() is not used by any code at this point. Since a
> default weak implementation exists, there is no need to keep this
> arch-specific definition around. Remove it along with the now-redundant
> profile header includes.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> ---
>  arch/mips/kernel/smp.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 0f28b4a62e72..7f4b395b090d 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -10,7 +10,6 @@
>  #include <linux/delay.h>
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
> -#include <linux/profile.h>
>  #include <linux/smp.h>
>  #include <linux/spinlock.h>
>  #include <linux/threads.h>
> @@ -487,14 +486,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *tidle)
>  }
>  #endif
>  
> -#ifdef CONFIG_PROFILING
> -/* Not really SMP stuff ... */
> -int setup_profiling_timer(unsigned int multiplier)
> -{
> -	return 0;
> -}
> -#endif

the weak implementation returns -EINVAL, which then fails the
write_profile() call. This is a different bahvavior then the code
above. Do I miss something ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]