mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Alireza Feyzabadi Farahani <arfa79lg@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: ALSA: Skip tests when devices are unavailable
Date: Sat, 26 Sep 2026 18:55:34 +0200	[thread overview]
Message-ID: <arf5Bp6v36JoNH76@sirena.org.uk> (raw)
In-Reply-To: <20260926095756.2051290-1-arfa79lg@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

On Sat, Sep 26, 2026 at 09:57:56AM +0000, Alireza Feyzabadi Farahani wrote:
> A kernel built without CONFIG_SND exposes no ALSA devices. In that
> environment, the mixer and PCM tests currently report success with a
> zero-test plan, while the userspace timer tests fail when opening
> /dev/snd/timer. Neither result accurately describes an unsupported test
> environment.
> 
> Report KSFT_SKIP when no sound cards are detected and when the timer
> device is unavailable. Keep the PCM missing-card failures when a matching
> hardware configuration says that a card should exist, and continue to
> fail timer opens for unexpected errors.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218479

The timer tests are clearly a good fix here but the other two programs
are a lot less clear - they aren't reporting any false errors, they're
just reporting a pass as they found no sound cards and therefore no
problems on them.  Or to put it another way all the available sound
cards were fine.  We don't know if this was due to missing configs, or
just that the machine physically has no sound cards (eg, a VM).  I'd at
least make this two patches, or TBH just leave the PCM and mixer tests
alone.  They certainly don't have an issue that needs fixing in the same
way that the timer test does.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2026-09-26 16:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26  9:57 Alireza Feyzabadi Farahani
2026-09-26 16:55 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arf5Bp6v36JoNH76@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=arfa79lg@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=shuah@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®