From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE2852FD1CA for ; Sun, 27 Sep 2026 14:54:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790520879; cv=none; b=slXaV1TZSyr4KPOCyeV90Fsp3qAvTFz3cNMUr6qOFzWeIC14+HOyhGkOrn1caP1jICRWpptWVHTq8I4RrA6hkq/sjKyu3PI3gKPdxs9DmwRc5JD32fRWYvQKLkcG5qSDvlXI/gB+HXycDBgofUrRo4AJukXi54zMwgWrAx9X42M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790520879; c=relaxed/simple; bh=yKI5V/O0xPS9DO8JxOaTTj+A0oMs8grfiPaICIe2IbI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=musTQru+3Acn0+bRVvKYIWn8H1poAoMrZ8BVSgSxK8/i/ffP9s5jx9Nf0b7BNzaGJWXBra3k5UX/GoKhWXwE9lAWxLL3JIuENQXR08tyTCsUysiUgaY9iy0iXG2d1GZ/cGE8LnwOnyW86Zd7lBa5U2eTUcOZwevwi4IkvHHVQ7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nNpfihw9; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nNpfihw9" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49ffde3cec6so4146785e9.3 for ; Sun, 27 Sep 2026 07:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790520876; x=1791125676; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ktsh/JgcSNmnNKAcVLzISoygMwOgNOsVbgbRCXSNX9I=; b=nNpfihw9oeOfJKV/D+DG9dcYWpMKwPIJ4sA4ZQPPjJA3fcxX/9V2R8orn6HAwf/UkY 2zCPnMNHez4OlcDGBjNhWD/sbRGjkPOUjttoS61evAoZn8mUKm+TajSo/LmprAL/bUEf JeFospjGCDqN9InDGBO+geUQwHpO4qmRu9E8v4+9Gw+mt461bLCPCaf2zmx3cou+g+8f w/uEN7G53HL5f1Kh+oDvd0d/Mu0coFLjSG/BieZHwx6mDdkVZW+RhQMPUgkFe0GONF7s hwGiyRVWrywJ98xS1+6M1VoFZaNjeSUzu3iMtKZZYqn7OoqrN183+wqjVvt5Q+u/Uvx+ 0KjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790520876; x=1791125676; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ktsh/JgcSNmnNKAcVLzISoygMwOgNOsVbgbRCXSNX9I=; b=QXeKhcqfjRRorXtDrEpaBDwz2P76H3c0ukDb7r7t0WksF9zs4L7vaevOmHVZk98phC hNDm5Iv5nhgK54NVBod18FpQOpPuYzd8owQOtKQfVH9zh7R1X0qQ5acCUvgec7F9TDC2 34FP3uxo0OchU8sEjs3l3PxsYjVoLjFTepHqsnL93QCyTmpMcSWzgeCI0y1NM3IF3DAD EHAVcRaBJhce1FYMh+GofE7axSHh4IEqc9jPrU9K3zlcqqrAc2hIOmS8kR9AV6lpM5Kn 1divivFJ3OGquqO87hO5yw66/BBRkM5qy4kMyn6PmlcxEHjpK7laVbKoxTujaIaOw0pa DbTQ== X-Forwarded-Encrypted: i=1; AKwUvBzrmQOSUvfoco+TDtu3+35y1pUCyrrnFPMxAG04mGXzhRBI/LFDON/f1ocUZuCuwH8SgzzHW9sV2xyX184=@vger.kernel.org X-Gm-Message-State: AFuF++kLSESUStjONWqyLLLFHPRmsIzwK7jZo8tWBFI0Gy28RUe0iWHg X6XeZc8UY1buJOldwfVkQoWA9ZdZSWElpxwQksvBkmiM3P1QdTZ0y33j X-Gm-Gg: AYBFou3cRVK2zk4oYDdy1gblS+esPL8yRQcOXc1Zg7jmlW8/PyNlz2LtnPm9eCxLNlD UcGRD29bNZSLP8SX/Ty3noYnfrj0dh+LPLt+oS8tAb1L7+Dp8QCopnLrJ11+nXj3yO2Ai5Fy5LL JESQ35R8hcyJ+29tMijnO1eBrcy92lvpEalVuBogZPQ9B0gKnwOrdMUccUGjIhKQ6zjYRV92WTX 4PpARqXE8FPOvqzJTgEkloZa/aDTbQe/c+KZm4Yao7HFOmkIwdB83DQUo7VqUqIkSlM7VJgWGtJ 70dHtfMhKNlczZkujRJONBWq+o7jxxAg0l3EY9XbPpaZGZRmOM9JcutyxrqdKzMQmVr7X9V2LME uFoOyLBVfQWDBthtOmR6aH1t79AjrkrQw7AaLGj6+c7SObkYrfDlvx6HoZwdxJBskuixQmiJmDH QJtLF72DvlchrlfClr4VX7fm2I65LOJTJAYENuNPJBq148dEyzSpKuNiKKalSzhc5rw/k2T/+y9 Q42kWU= X-Received: by 2002:a05:600d:486:20b0:49f:e8bf:221a with SMTP id 5b1f17b1804b1-49fe8bf24fbmr135716955e9.22.1790520875905; Sun, 27 Sep 2026 07:54:35 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a0018dd0ffsm69292305e9.2.2026.09.27.07.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2026 07:54:35 -0700 (PDT) Date: Sun, 27 Sep 2026 17:54:30 +0300 From: Dan Carpenter To: Zihan Xi Cc: pc@manguebit.org, linkinjeon@kernel.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com, dhowells@redhat.com, stfrench@microsoft.com, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel test robot , Luxing Yin Subject: Re: [PATCH] smb: client: avoid NULL resp_iov dereference Message-ID: References: <20260926132208.23360-1-zihanx@nebusec.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260926132208.23360-1-zihanx@nebusec.ai> On Sat, Sep 26, 2026 at 01:22:08PM +0000, Zihan Xi wrote: > compound_send_recv() only populates response vectors when resp_iov is > non-NULL. The final pre-authentication hash update nevertheless > dereferences resp_iov[0] whenever all compound requests complete. > > Guard the update with resp_iov to match the response-buffer handling and > avoid a NULL pointer dereference on callers that do not request response > vectors. > > Fixes: 62432a3f5145 ("cifs: Clean up some places where an extra kvec[] was required for rfc1002") > Cc: stable@vger.kernel.org > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/202609241449.HlHmnZFZ-lkp@intel.com/ Originally the idea was that I would review these and filter out the false positives, but these days people use lei to read email so they recieve the unfiltered warnings. The zero day bot should probably put a "Unfiltered warning" note at the top to let people know the warning hasn't been reviewed. regards, dan carpenter