mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: ast@kernel.org, Greg Ungerer <gerg@polyxeno.com>,
	daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
	memxor@gmail.com, martin.lau@linux.dev, song@kernel.org,
	yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com,
	ihor.solodrai@linux.dev, jserv@ccns.ncku.edu.tw,
	marscheng@google.com, eleanor15x@gmail.com,
	linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	bpf@vger.kernel.org, Daniel Palmer <daniel@thingy.jp>
Subject: Re: [PATCH bpf-next v5] m68k, bpf: Add initial BPF JIT compiler support
Date: Mon, 28 Sep 2026 04:32:07 +0800	[thread overview]
Message-ID: <arl9R1pfMU1k7-Ur@google.com> (raw)
In-Reply-To: <CAMuHMdX6rtJDZUqhLf+-U=9=yTkhJtYUU_Ru1GE=7o0qXu+d6Q@mail.gmail.com>

On Sun, Sep 27, 2026 at 04:03:15PM +0200, Geert Uytterhoeven wrote:
> Hi Kuan-Wei,
> 
> On Fri, 28 Aug 2026 at 12:50, Greg Ungerer <gerg@polyxeno.com> wrote:
> > On 24/8/26 02:38, Kuan-Wei Chiu wrote:
> > > Add a BPF JIT compiler for the m68k architecture.
> > >
> > > The JIT generates m68k machine code targeting m68020+ processors and
> > > coldfire parts with an mmu (ISA_B/ISA_C). It excludes plain 68000/68010
> > > and non-mmu coldfire processors, as it relies on 32-bit branch
> > > displacements (b<cc>.l) to handle large bpf programs.
> > >
> > > Tested with the test_bpf.ko:
> > > test_bpf: Summary: 1061 PASSED, 0 FAILED, [1049/1049 JIT'ed]
> > > test_bpf: test_tail_calls: Summary: 10 PASSED, 0 FAILED, [10/10 JIT'ed]
> > >
> > > Tested-by: Daniel Palmer <daniel@thingy.jp>
> > > Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> 
> Thanks for your (impressive) patch!
> 
> > From here it is really up to Geert now if and when he will pick this up.
> > I am happy with this patch in its current form.
> 
> Who am I to block this feature? ;-)
> 
> > > --- a/arch/m68k/Kconfig
> > > +++ b/arch/m68k/Kconfig
> > > @@ -8,6 +8,7 @@ config M68K
> > >       select ARCH_HAS_CPU_FINALIZE_INIT if MMU
> > >       select ARCH_HAS_CURRENT_STACK_POINTER
> > >       select ARCH_HAS_DMA_PREP_COHERENT if M68K_NONCOHERENT_DMA && !COLDFIRE
> > > +     select HAVE_EBPF_JIT if MMU
> 
> Pleave move this to the other "select HAVE_*" lines below, to preserve
> sort order.

Ack. Will fix in the next version.

> 
> > >       select ARCH_HAS_SYNC_DMA_FOR_DEVICE if M68K_NONCOHERENT_DMA
> > >       select ARCH_HAVE_NMI_SAFE_CMPXCHG if RMW_INSNS
> > >       select ARCH_MIGHT_HAVE_PC_PARPORT if ISA
> 
> I think you should also update
> Documentation/features/core/eBPF-JIT/arch-support.txt.
> 
I wasn't aware of this doc.
Will update it and send out v6 shortly.

Regards,
Kuan-Wei

      reply	other threads:[~2026-09-27 20:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 16:38 Kuan-Wei Chiu
2026-08-28 10:50 ` Greg Ungerer
2026-09-27 14:03   ` Geert Uytterhoeven
2026-09-27 20:32     ` Kuan-Wei Chiu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arl9R1pfMU1k7-Ur@google.com \
    --to=visitorckw@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=daniel@thingy.jp \
    --cc=eddyz87@gmail.com \
    --cc=eleanor15x@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@polyxeno.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=marscheng@google.com \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®