From: Herbert Xu <herbert@gondor.apana.org.au>
To: T Pratham <t-pratham@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Sebin Francis <sebin.francis@ti.com>,
Manorit Chawdhry <m-chawdhry@ti.com>,
Vishal Mahaveer <vishalm@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 04/15] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal
Date: Mon, 28 Sep 2026 15:20:29 +1000 [thread overview]
Message-ID: <arn5HcrQcER2_dio@gondor.apana.org.au> (raw)
In-Reply-To: <604ddec3-bf19-4a41-8fc3-c4ec949e4e03@ti.com>
On Thu, Sep 24, 2026 at 09:09:33PM +0530, T Pratham wrote:
>
> As an aside, my LLM suggests me to instead do:
> - .cra_reqsize = sizeof(struct dthe_aes_req_ctx),
> + .cra_reqsize = sizeof(struct dthe_aes_req_ctx) + CRYPTO_DMA_PADDING,
>
> Doesn't look to me that it is doing same thing as
> crypto_skcipher_set_reqsize_dma(). Your thoughts?
That's exactly what you should do. I'm very impressed with how
far LLM has come over the past couple of months :)
With the extra space, you can then safely use the reqctx_dma
helpers to access the aligned context.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-09-28 5:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 10:22 [PATCH v5 00/15] Fix several issues in DTHEv2 driver T Pratham
2026-09-18 10:22 ` [PATCH v5 01/15] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() T Pratham
2026-09-18 10:22 ` [PATCH v5 02/15] crypto: ti - Fix spinlock inconsistency in DTHEv2 T Pratham
2026-09-18 10:22 ` [PATCH v5 03/15] crypto: ti - Fix potential memory corruption on highmem pages T Pratham
2026-09-18 10:22 ` [PATCH v5 04/15] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal T Pratham
2026-09-23 5:51 ` Herbert Xu
2026-09-24 15:39 ` T Pratham
2026-09-28 5:20 ` Herbert Xu [this message]
2026-09-18 10:22 ` [PATCH v5 05/15] crypto: ti - Trim scatterlists to correct length in AES T Pratham
2026-09-18 10:22 ` [PATCH v5 06/15] crypto: ti - Align buffers to cacheline for DMA T Pratham
2026-09-18 10:22 ` [PATCH v5 07/15] crypto: ti - Separate padding buffer for src and dst T Pratham
2026-09-18 10:22 ` [PATCH v5 08/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES T Pratham
2026-09-18 10:22 ` [PATCH v5 09/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD T Pratham
2026-09-18 10:22 ` [PATCH v5 10/15] crypto: ti - Terminate DMA on all error paths in AES to clear descriptors T Pratham
2026-09-18 10:22 ` [PATCH v5 11/15] crypto: ti - Terminate DMA on all error paths in AEAD " T Pratham
2026-09-18 10:22 ` [PATCH v5 12/15] crypto: ti - Do AEAD software fallback on only ENOMEM T Pratham
2026-09-18 10:22 ` [PATCH v5 13/15] crypto: ti - Correct AEAD tag operations against dma cache invalidation T Pratham
2026-09-18 10:22 ` [PATCH v5 14/15] crypto: ti - Change lengths in AES to u64 to avoid potential overflows T Pratham
2026-09-18 10:22 ` [PATCH v5 15/15] crypto: ti - Change lengths in AEAD " T Pratham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arn5HcrQcER2_dio@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=praneeth@ti.com \
--cc=sebin.francis@ti.com \
--cc=t-pratham@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®