From: Hyunchul Lee <hyc.lee@gmail.com>
To: Matthias Goergens <matthias.goergens@gmail.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
ntfs@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] ntfs: do not turn an unmappable runlist fragment into delalloc on write
Date: Mon, 28 Sep 2026 10:46:28 +0900 [thread overview]
Message-ID: <arnG9F6dyChrAWNg@hyunchul-PC02> (raw)
In-Reply-To: <army_CjLBEcEiJ_o@hyunchul-PC02>
On Mon, Sep 28, 2026 at 09:21:16AM +0900, Hyunchul Lee wrote:
> Hi Matthias,
>
> > + /*
> > + * As in ntfs_attr_vcn_to_rl(): a runlist fragment that could not be
> > + * mapped is not a hole. Treating it as one would put a delalloc
> > + * extent over clusters that are allocated on disk but unknown to us.
> > + */
> > + if (lcn == LCN_RL_NOT_MAPPED) {
>
> We should handle LCN_ENOENT also.
Please ignore the my previous comment about handling LCN_ENOENT. I had
misunderstood the code.
>
> > + up_write(&ni->runlist.lock);
> > + mutex_unlock(&ni->mrec_lock);
> > + return map_err == -ENOMEM ? -ENOMEM : -EIO;
> > + }
> > +
> > max_clu_count = min(max_clu_count, rl->length - (vcn - rl->vcn));
> > if (max_clu_count == 0) {
> > ntfs_error(inode->i_sb,
> > --
> > 2.55.0
> >
>
> --
> Thanks,
> Hyunchul
--
Thanks,
Hyunchul
next prev parent reply other threads:[~2026-09-28 1:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 15:39 [PATCH] ntfs: fail the mount when $MFT needs its own extent records Matthias Goergens
2026-09-23 1:16 ` Hyunchul Lee
2026-09-27 5:08 ` [PATCH v2 0/6] ntfs: fix the $MFT bootstrap hang and reads of unmapped runlist ranges Matthias Goergens
2026-09-27 5:08 ` [PATCH v2 1/6] ntfs: do not map an unmappable runlist fragment as a hole Matthias Goergens
2026-09-27 23:03 ` liubaolin
2026-09-27 5:08 ` [PATCH v2 2/6] ntfs: do not turn an unmappable runlist fragment into delalloc on write Matthias Goergens
2026-09-28 0:21 ` Hyunchul Lee
2026-09-28 1:46 ` Hyunchul Lee [this message]
2026-09-27 5:08 ` [PATCH v2 3/6] ntfs: fail the mount when $MFT needs its own extent records Matthias Goergens
2026-09-27 5:08 ` [PATCH v2 4/6] ntfs: do not map a vcn as a hole when its runlist lookup failed Matthias Goergens
2026-09-28 1:09 ` Hyunchul Lee
2026-09-27 5:08 ` [PATCH v2 5/6] ntfs: fail the mount when $MFT's data size exceeds its allocation Matthias Goergens
2026-09-27 5:08 ` [PATCH v2 6/6] ntfs: reject non-resident attributes whose sizes exceed their allocation Matthias Goergens
2026-09-28 1:42 ` Hyunchul Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arnG9F6dyChrAWNg@hyunchul-PC02 \
--to=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.goergens@gmail.com \
--cc=ntfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®