mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartu Alev <bartualev@gmail.com>
Cc: Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Mika Westerberg <westeri@kernel.org>,
	Mario Limonciello <superm1@kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Ignore AC adapter wakeup on ASUS FA507
Date: Mon, 28 Sep 2026 12:54:07 +0300	[thread overview]
Message-ID: <aro5Pz000gT7Q9t1@ashevche-desk.local> (raw)
In-Reply-To: <20260927014212.302743-1-bartualev@gmail.com>

On Sun, Sep 27, 2026 at 04:42:12AM +0300, Bartu Alev wrote:
> The ASUS TUF Gaming A15 FA507 wakes from s2idle whenever the AC
> adapter is plugged in or unplugged.
> 
> In the CPMGPIO0 SSDT, GPIO pin 23 (0x0017) is declared in the
> \_SB.GPIO._AEI resource template as:
> 
>     GpioInt (Edge, ActiveBoth, ExclusiveAndWake, PullNone, 0x0000,
>              "\\_SB.GPIO", 0x00, ResourceConsumer, ,)
>              { 0x0017 }
> 
> and the corresponding \_SB.GPIO._EVT handler issues a device wake
> notification for the AC adapter on pin 23 events:
> 
>     Case (0x17)
>     {
>         Notify (\_SB.ACAD, 0x02) // Device Wake
>         Sleep (0x05)
>         Notify (\_SB.ACAD, 0x80) // Status Change
>     }
> 
> Both AC plug and unplug transitions therefore trigger a spurious
> wakeup from s2idle. Add an ignore_wake quirk for this pin.

...

> I have one question: this issue is probably present across the whole
> TUF series. If I acpidump more TUF models in the future and they all map
> to the same GPIO pin, should the quirk list the board names one by
> one (FA507, FA506, FA707, ...) or match on the product family ('ASUS TUF
> Gaming A15', 'ASUS TUF Gaming A16' or 'ASUS TUF Gaming')?
> 
> The DMI outputs on my FA507NV laptop are as follows:
> 
>   board_name:     FA507NV
>   board_vendor:   ASUSTeK COMPUTER INC.
>   product_family: ASUS TUF Gaming A15
>   product_name:   ASUS TUF Gaming A15 FA507NV_FA507NV

I can't guarantee that, so the safest approach is to go with the one-by-one
quirk(s). If you get a confirmation from the vendor (ASUSTeK) in writing
supporting your idea, the patch will be welcome, of course!

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-09-28  9:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27  1:42 Bartu Alev
2026-09-28  9:41 ` Mika Westerberg
2026-09-28 10:05   ` Andy Shevchenko
2026-09-28 13:05   ` Mario Limonciello
2026-09-28  9:54 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aro5Pz000gT7Q9t1@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bartualev@gmail.com \
    --cc=brgl@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=superm1@kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®