From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: phucduc.bui@gmail.com
Cc: Adrian Ng <adrianhoyin.ng@altera.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] gpio: realtek-otto: Handle errors from optional IRQ lookup
Date: Mon, 28 Sep 2026 11:57:31 +0200 [thread overview]
Message-ID: <aro6C_SWBGF44z5E@black.igk.intel.com> (raw)
In-Reply-To: <20260814043028.12548-1-phucduc.bui@gmail.com>
On Fri, Aug 14, 2026 at 11:30:25AM +0700, phucduc.bui@gmail.com wrote:
> platform_get_irq_optional() returns a positive IRQ number on success or
> a negative error code on failure. For an optional IRQ, -ENXIO indicates
> that no optional IRQ is available. Other errors, such as -EPROBE_DEFER
> and -EINVAL, should be propagated so that the caller can handle them
> appropriately.
>
> Propagate negative errors other than -ENXIO.
Have you read the discussion [1]?
It would be better to make platform_get_irq_optional() to be actually optional.
[1]: https://lore.kernel.org/lkml/20220212201631.12648-1-s.shtylyov@omp.ru/
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-09-28 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 4:30 phucduc.bui
2026-08-14 4:30 ` [PATCH 2/4] gpio: mlxbf3: " phucduc.bui
2026-08-14 4:30 ` [PATCH 3/4] gpio: mlxbf2: " phucduc.bui
2026-08-14 4:30 ` [PATCH 4/4] gpio: altera: " phucduc.bui
2026-09-01 15:55 ` [PATCH 1/4] gpio: realtek-otto: " Bartosz Golaszewski
2026-09-14 11:56 ` Linus Walleij
2026-09-28 9:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aro6C_SWBGF44z5E@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=adrianhoyin.ng@altera.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phucduc.bui@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®