From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej2-f43.google.com (mail-ej2-f43.google.com [74.125.228.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E4A54E50D5 for ; Mon, 28 Sep 2026 15:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790608165; cv=none; b=ETYVbC8zQHuLH8RSVtDjLG30KccZGdUA2nT7NJxtOIkZ9T+6azp4GmTdhSjSZy7Todxxd4gO3lhNvsd5mYL27SmTAoCFIo153WZRVtj1ytkVcyx4yfOWjVUR9FIcQC1pDYeKK/1SbRw1qE4CYKwfmBibZY3scgVIhk0wd9guQLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790608165; c=relaxed/simple; bh=V128fD04ij55ZxJr3/qfR5fWUCfstwSbaVgWF34gnn8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=daR5iRadFg2OC+7FT9TvdA0Ir8I3dyDezxAQ4VFUHi8gT8o1eLdjUg3pebdfWDj/0JWs+JSv8bifsHaL+TP2XvlIjWTqxEjoioNt5yYhitrQHPniTrjZCFYpbMfDH9vZV1Ww9Cdm6oEFxQKVEghWzN9JSu7lLPFx+g3hBa7q0AE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HSfTL2b5; arc=none smtp.client-ip=74.125.228.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HSfTL2b5" Received: by mail-ej2-f43.google.com with SMTP id a640c23a62f3a-c2af876539fso324561266b.2 for ; Mon, 28 Sep 2026 08:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790608161; x=1791212961; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:date :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7ePUtRIIdzKxmcepIuM7i9rcIIVMHWU1yVMYxV/ojck=; b=HSfTL2b5KQ+6ZIkApzMXSqRHvMcHEhRbILvfNcEJDpptYcJ8RDebTZjLyi/Wu+a1Q8 nGjTcp0dFfHqjzkJIann+OD5Pmyk4pd0YAygbIOJS9LqWOg96m/hLnFG0fACfOhiWoIk WQcXMNKbCR/vMnHe/dBKF01UqN+IPUtZxex8DsHebepjNZm7RsTBL4OluB+4R6BEMyeT SflCyzexbVh2F0bpB9tH+LeWmVC4r6YZU/6UjfBtC4vZduLj4daDdlcCZ0XTcsIL4f/L ot1U4xxeLguh60AaICyWOIehp89YVvja7wPqLsIj3DeAYuGAUoi2GFdEEXVOLgWhiW6e kORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790608161; x=1791212961; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:date :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=7ePUtRIIdzKxmcepIuM7i9rcIIVMHWU1yVMYxV/ojck=; b=zTVv6LwTmhy9ZPE5WDtFtqwmJSdP/3QYlRn3QbBN3QJLou3I6HfMZBExN30CSl1M2L jVHOxXbIz4XWrU7MkLhE2H1tpjrpexV3jrSqwndPCwrlNfEVkVnnE4yDBMrWIRCjI5aN e9sJgda54vKkOvnfBaknpMHWS2kqa0+mdpvmGzapjeYJvj2G/BysagRzrDrV2uNWJaqa 7BthQDYDj7TwpzotvmctOPuq2eI2U64uh9+C6UVpxR0a+CZIfzfz8wOV0PXmS1SVoifH 0AHb2wzWE/aj3BGluxrXaZHgJizfLmgGUhN1XS1hJvpuY3jaL79cEfGk+KomM28DOY2o 2BIQ== X-Forwarded-Encrypted: i=1; AKwUvBx9ZxTyjH0D5k0pUQmbJcpgQFj7XDXha7Zeg2ratSm08tFECLmqle8m4g+QA+ThGf/iHzLzlQiQ7fUml7M=@vger.kernel.org X-Gm-Message-State: AFuF++ndXlddiFicK2BiBUisnKh9juM4kzJlSCBfJ8tCsufPPvVDBfWY /U1LX5wCTLkquF8IZl9Ee5FhE2ywIeDN1qsgY7wVgPHJbW9vWu5b3k55 X-Gm-Gg: AYBFou23fz8SF/QQmAQ07Fp5xZubPlwaAa9BtN/LH+zmxHGs2htMd2bxyoquf7EeOoJ eKZl1OK6+4KrUQ+wOTYn6YjJxInjuqVUk3lzOV0yl5gUi2gHJTYDBZ1CcwqOLQFW0qsjMquJGLp OYVS+GL9/9v0whE8bNQ5GcR2EvRXT7cN6APUa7rBljxNBS8FLJQDDOOxX5hOLVcUr+irLtQGHtd jvBJQ1PzDAiiPaTSu+dsWzOs5WHp4biywV61ufMLj0dxdggzW2xHXLiTkNP8dcgNyhEPOrm9Vgp XoRJPARyxMGz3P8nxbSMpUQLk196IxURRu6K/JipiZE8G+hbDohjNW0tyAcPAaE1iL9wAEXs+bb A4CAV0y+PlhXwTqjj1jVcZj01UpD7j2YPlgrGUYC8n+++sB4PTE/02/Y5QDBGXTB9s/EuCHuQQY cJFNU8Jov5JZeUNyJeEb3/v9L5Zv2XbueKgig= X-Received: by 2002:a17:907:c602:10b0:c2b:4142:2db1 with SMTP id a640c23a62f3a-c2b41424722mr392606866b.40.1790608160979; Mon, 28 Sep 2026 08:09:20 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2dbfde3194sm297220266b.4.2026.09.28.08.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 08:09:20 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 28 Sep 2026 17:09:18 +0200 To: Hao Ge Cc: Hao Ge , Suren Baghdasaryan , "David Hildenbrand (Arm)" , "Lorenzo Stoakes (ARM)" , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Kent Overstreet , Andrew Morton , linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sashiko , stable@vger.kernel.org Subject: Re: [PATCH v10 2/6] alloc_tag: clean up the populate failure path Message-ID: References: <20260915070001.113559-1-hao.ge@linux.dev> <20260915070001.113559-3-hao.ge@linux.dev> <60642a7f-2949-428a-8290-40d69c989a77@linux.dev> <1dff448c-9cbe-4276-bca1-d91283b0c7b4@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Sep 28, 2026 at 01:09:13PM +0200, Uladzislau Rezki wrote: > On Thu, Sep 17, 2026 at 10:32:48AM +0800, Hao Ge wrote: > > Hi Suren、David、Lorenzo > > > > On 2026/9/17 09:12, Hao Ge wrote: > > > Hi Suren > > > > > > On 2026/9/17 03:07, Suren Baghdasaryan wrote: > > >> On Wed, Sep 16, 2026 at 9:31 AM Suren Baghdasaryan wrote: > > >>> > > >>> On Tue, Sep 15, 2026 at 11:00 PM Hao Ge wrote: > > >>>> > > >>>> Hi Suren > > >>>> > > >>>> Thanks for you review. > > >>>> > > >>>> On 2026/9/16 05:09, Suren Baghdasaryan wrote: > > >>>>> On Mon, Sep 14, 2026 at 11:59 PM Hao Ge wrote: > > >>>>>> > > >>>>>> The reservation is already stored in the maple tree when > > >>>>>> vm_module_tags_populate() fails. A failed load never unloads the > > >>>>>> module, so nothing releases the entry. Release it and roll > > >>>>>> module_tags.size back. Without the rollback a concurrent load that > > >>>>>> already passed needs_section_mem() can reuse the freed gap, skip > > >>>>>> vm_module_tags_populate() and write to unmapped memory. > > >>>>>> > > >>>>>> vmap_pages_range() may have installed some PTEs before failing. A > > >>>>>> retry to populate the same range would BUG on them, so undo them, > > >>>>>> but only if vmap actually ran. > > >>>>>> > > >>>>>> Fixes: 4835f747d3ed ("alloc_tag: support for page allocation tag compression") > > >>>>>> Fixes: 0f9b685626da ("alloc_tag: populate memory for module tags as needed") > > >>>>> > > >>>>> If a patch fixes two other patches, it likely needs to be split so > > >>>>> that each part fixes one patch only. But read on please. I'm not sure > > >>>>> if one of the fixes is correct. > > >>>>> > > >>>> > > >>>> Kept them in one patch because they only make sense together. > > >>>> > > >>>> After a failed populate the reservation is released and the > > >>>> size rolled back, so the next load takes the same gap and calls > > >>>> vm_module_tags_populate() again, and that retry would trip over > > >>>> the PTEs the failed vmap left behind. > > >>>> > > >>>> Without the rollback a load that already passed needs_section_mem() > > >>>> just reuses the gap, skips populate and writes to unmapped memory. > > >>>> So splitting them leaves each half broken. > > >>> > > >>> Yeah, that's why I think vmap_pages_range() cleanup should be a > > >>> completely separate patch with vmap_pages_range() doing cleanup > > >>> itself. > > >>> > > > > > > I think I get where you're coming from now. > > > Thanks for taking the time to explain. > > > > > >>>> > > >>>>>> Reported-by: Sashiko > > >>>>>> Cc: stable@vger.kernel.org > > >>>>>> Signed-off-by: Hao Ge > > >>>>>> --- > > >>>>>> mm/alloc_tag.c | 10 ++++++++++ > > >>>>>> 1 file changed, 10 insertions(+) > > >>>>>> > > >>>>>> diff --git a/mm/alloc_tag.c b/mm/alloc_tag.c > > >>>>>> index 2070e682fe10..95ddf5b743d0 100644 > > >>>>>> --- a/mm/alloc_tag.c > > >>>>>> +++ b/mm/alloc_tag.c > > >>>>>> @@ -804,6 +804,13 @@ static int vm_module_tags_populate(void) > > >>>>>> next_page, PAGE_SHIFT) < 0) { > > >>>>>> release_pages_arg arg = { .pages = next_page }; > > >>>>>> > > >>>>>> + /* > > >>>>>> + * vmap_pages_range() only runs once all pages were > > >>>>>> + * allocated, and it may have installed some mappings > > >>>>>> + * before failing. Undo them. > > >>>>> > > >>>>> If vmap_pages_range() failed to map the range, why should we need to > > >>>>> undo it? If it indeed leaves some partial mapping when failing then I > > >>>>> would argue that vmap_pages_range() should be undoing these partial > > >>>>> mappings itself before returning the error. > > >>>>> > > >>>> Yeah it does - none of the paths under vmap_pages_range() undo themselves on error. > > >>> > > >>> Hmm. I wonder if this behavior is intentional or requires a fix. The > > >>> only possible reason I can think of is performance but I can't imagine > > >>> a failure to map is a performance-critical case. > > >>> > > >>> +David Hildenbrand (Red Hat), +Lorenzo Stoakes (Oracle) what do you > > >> > > >> Huh, my gmail thinks you are still at your previous companies :) > > >> > > > > > > I manually fixed it on the mailing list for this thread. > > > > > >>> guys think? Shouldn't vmap_pages_range() undo its possible partial > > >>> mapping when it fails? > > >>> > > >>> > > >>>> pcpu_map_pages does perform cleanup on its own as well. There may be other similar sites. > > >>>> https://elixir.bootlin.com/linux/v7.3-rc3/source/mm/percpu-vm.c#L255 > > >>>> so I did the same here. > > >>>> > > >>>> If we really want vmap_pages_range() to handle this cleanup internally, I believe that would > > >>>> be a relatively large change, and we would need to consider many more cases. So I think we keep > > >>>> the current behaviour for now. > > >>> > > >>> Yeah, I understand it would require a deeper cut but if that's the > > >>> right way to handle this we might as well do that. Let's see what MM > > >>> folks think. > > >>> > > > > > > Sounds good to me. Let's wait and hear what the MM folks say. > > > > > > > I just looked into the call sites for __vmap_pages_range. > > And I found there's a bug in one vmalloc caller [1]. > > When gfp_mask has __GFP_NOFAIL, the code keeps retrying > > __vmap_pages_range. If there are leftover PTE mappings, > > this can trigger a BUG(); [2] > > https://elixir.bootlin.com/linux/v7.3-rc3/source/mm/vmalloc.c#L3946 [1] > > https://elixir.bootlin.com/linux/v7.3-rc3/source/mm/vmalloc.c#L121 [2] > > > Indeed the below code is incomplete: > > > /* > * page tables allocations ignore external gfp mask, enforce it > * by the scope API > */ > flags = memalloc_apply_gfp_scope(gfp_mask); > do { > ret = __vmap_pages_range(addr, addr + size, prot, area->pages, > page_shift, nested_gfp); > if (nofail && (ret < 0)) > schedule_timeout_uninterruptible(1); > } while (nofail && (ret < 0)); > memalloc_restore_scope(flags); > > > and it should be fixed. As the __vmap_pages_range() can actually fail > and leave some installed mappings, we have to perform some cleanups > on failure or on repeat(if nofail is true). > > Below code: > > + /* > + * vmap_pages_range() only runs once all pages were > + * allocated, and it may have installed some mappings > + * before failing. Undo them. > + */ > + if (nr == more_pages) > + vunmap_range(phys_end, phys_end + (nr << PAGE_SHIFT)); > > we can use but we need to check if partially mapped space is not an > issue for the vunmap_range(). And it looks like it is not. > > > @@ -3953,8 +3990,15 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > do { > ret = __vmap_pages_range(addr, addr + size, prot, area->pages, > page_shift, nested_gfp); > - if (nofail && (ret < 0)) > - schedule_timeout_uninterruptible(1); > + if (ret < 0) { > + /* > + * __vmap_pages_range() may have installed some mappings > + * before failing. Undo them before returning or retrying. > + */ > + vunmap_range(addr, addr + size); > + if (nofail) > + schedule_timeout_uninterruptible(1); > + } > } while (nofail && (ret < 0)); > memalloc_restore_scope(flags); > > And looking further. If the __vmap_pages_range()/__vmap_pages_range_noflush() and friends fail, a proper cleanups should be done inside, IMO. But i am checking callers and see that some do some not: __vunmap_range_noflush( vmalloc_shadow(start), vmalloc_shadow(start + clean * PAGE_SIZE)); __vunmap_range_noflush( vmalloc_origin(start), vmalloc_origin(start + clean * PAGE_SIZE)); kmsan_ioremap_page_range() it does clean ups; kmsan_vmap_pages_range_noflush() looks like does not care in shadow.c; __vmalloc_area_node() as noted, it is broken as there is a BUG() on next try if nofail; pcpu_map_pages() it does cleanups. ... and so on. -- Uladzislau Rezki