mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Hitesh Patel <hitesh@ebytelogic.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Robert Foss <rfoss@kernel.org>,
	linux-i2c@vger.kernel.org,  linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, ravi@ebytelogic.com
Subject: Re: [PATCH v2] i2c: qcom-cci: always enable SCL clock stretching
Date: Tue, 29 Sep 2026 01:37:28 +0200	[thread overview]
Message-ID: <arr57tHBYx1MowW7@zenone.zhora.eu> (raw)
In-Reply-To: <20260921131954.1690578-1-hitesh@ebytelogic.com>

Hi Hitesh,

Please don't send next versions as --in-reply-to, it makes life
difficult.

On Mon, Sep 21, 2026 at 06:49:54PM +0530, Hitesh Patel wrote:
> Every CCI timing table except the msm8953 fast-plus one leaves SCL
> clock stretching disabled in MISC_CTL. A slave that holds SCL low is
> then not waited for: the master keeps its own clock timing and the
> transfer fails with a NACK or returns corrupt data.
> 
> This is hit with a camera reached through a GMSL serializer/
> deserializer I2C tunnel (MAX9296A/MAX96717 on the RB3 Gen2 vision
> mezzanine, SC7280 CCI v2 at 100 kHz). The deserializer acknowledges
> the address locally, forwards the transaction over the coax link and
> stretches SCL until the remote side has completed it, which takes well
> over one clock period. Without stretching the register reads of the
> sensor behind the link intermittently return garbage and writes are
> dropped, which shows up as random sensor init failures.
> 
> Clock stretching is part of the I2C specification for every speed
> mode and a device that does not stretch is unaffected by it, so there
> is no reason to make it a per-table parameter. Set the bit
> unconditionally and drop the scl_stretch_en field.
> 
> Signed-off-by: Hitesh Patel <hitesh@ebytelogic.com>

I'll wait for an ack from Konrad here.

Thanks,
Andi

  reply	other threads:[~2026-09-28 23:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 13:23 [PATCH] i2c: qcom-cci: enable SCL clock stretching in standard mode on CCI v2 Hitesh Patel
2026-09-21 11:34 ` Konrad Dybcio
2026-09-21 12:36   ` Hitesh Patel
2026-09-21 13:19 ` [PATCH v2] i2c: qcom-cci: always enable SCL clock stretching Hitesh Patel
2026-09-28 23:37   ` Andi Shyti [this message]
2026-10-05  4:27     ` Hitesh Patel
2026-10-05  8:30   ` Loic Poulain
2026-10-06 13:58   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arr57tHBYx1MowW7@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=hitesh@ebytelogic.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=ravi@ebytelogic.com \
    --cc=rfoss@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®