From: Frank Li <Frank.li@oss.nxp.com>
To: vjardin@free.fr
Cc: Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: lx2160a: set #pinctrl-cells on the pinmux node
Date: Mon, 28 Sep 2026 14:51:59 -0500 [thread overview]
Message-ID: <arrFXz-IsivCPBi6@SMW015318> (raw)
In-Reply-To: <20260928-for-upstream-lx2160a-pinctrl-cells-v1-1-4faa8a341cdd@free.fr>
On Mon, Sep 28, 2026 at 03:49:49PM +0200, Vincent Jardin via B4 Relay wrote:
> From: Vincent Jardin <vjardin@free.fr>
>
> Currently, we have this message at boot time:
> pinctrl-single 70010012c.pinmux: please update dts to use #pinctrl-cells = <2>
Avoid use "we have" ..
Just said
The below message show at boot time
...
>
> Let's declare it in the DT instead, the value is the one the
> driver already uses, so nothing else changes.
Add missing #pinctrl-cells = <2> to fix it.
Frank
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
> arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi
> index bccf2d673023..2085362ab0ea 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi
> @@ -1536,6 +1536,7 @@ pinmux_i2crv: pinmux@70010012c {
> reg = <0x00000007 0x0010012c 0x0 0xc>;
> #address-cells = <1>;
> #size-cells = <0>;
> + #pinctrl-cells = <2>;
> pinctrl-single,bit-per-mux;
> pinctrl-single,register-width = <32>;
> pinctrl-single,function-mask = <0x7>;
>
> ---
> base-commit: bf184a29ad1b33bd8922029eb0ca3f2866007258
> change-id: 20260928-for-upstream-lx2160a-pinctrl-cells-729533182b85
>
> Best regards,
> --
> Vincent Jardin <vjardin@free.fr>
>
>
>
prev parent reply other threads:[~2026-09-28 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 13:49 Vincent Jardin via B4 Relay
2026-09-28 19:51 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arrFXz-IsivCPBi6@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®