mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <netdev-bot+sashiko@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<sgoutham@marvell.com>
Subject: Re: [PATCH v3 net-next] octeontx2-af: pass devlink switch id and cache representor map
Date: Tue, 29 Sep 2026 08:09:01 +0530	[thread overview]
Message-ID: <arskxWnvfGGv-xMZ@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <179058473451.3145.9297107718800202799@kernel.org>

On 2026-09-28 at 14:08:54, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:
> Thank you for your contribution! Sashiko AI review found 7 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 (4) · Medium: 6 (3) · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] Turning off the eswitch now makes the AF forget the
>   representor PF before that PF has freed its hardware resources.
> - [Medium] struct esw_cfg_req grows from 32 bytes to 72 bytes:
>   switch_id[MAX_PHYS_ITEM_ID_LEN] and switch_id_len are appended after…
> - [Medium] The new call to rvu_rep_cache_reset() in __rvu_flr_handler()
>   sets rep_mode = 0 when the representor PF goes through FLR.
> - [Medium] The patch puts rep_pcifunc, rep_mode,
>   rswitch.switch_id/switch_id_len, rep_cnt and rep2pfvf_map under…
> - [Medium] Before this patch, rep_pcifunc was only ever set.
> - [Medium] rvu_mbox_handler_esw_cfg() reads req->switch_id_len from the
>   shared mailbox several times: once for the bounds check, once as the…
> - [Low] The switch-id plumbing the commit message describes has no
>   consumer.

ACK.

pw-bot: changes-requested

      reply	other threads:[~2026-09-29  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  8:26 Ratheesh Kannoth
2026-09-28  8:38 ` netdev-bot+sashiko
2026-09-29  2:39   ` Ratheesh Kannoth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arskxWnvfGGv-xMZ@rkannoth-OptiPlex-7090 \
    --to=rkannoth@marvell.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®