From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA283C3792 for ; Tue, 29 Sep 2026 05:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790660053; cv=none; b=kK/Nx6CMJBTROE8TxiB2u/uCIFy5CLr3WiW1e2RUSOCsXacd6E1UkkX3B1axfBRnu80SBydtoPnbYIvkKZ91jCKLPUZWhll3qkxR3bdsow7ASRo7+9C8ECz/6yuYC9TeGn/ymu11Etoxckvqo2Z80ihkwPvFprKSb6ncQQ7Kzrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790660053; c=relaxed/simple; bh=m2lqawFRROq7VOxJCYnJVdA4aB6TI0mUCVIlIeUuTzI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A+jfzQkRlF4J7BG+sop6pLWPKIVUBsrppswUyv/TVaRpwvaI6yZrFFYduKwyDj0sQcO8PqZHOZX7CBEYruipufNCQobfKi4PJP8nUILv2Fn6euh9kP2zpCRZ9Ng1Ub2TtPPvZPSU62JrR7GIVy88f+7AswDtgUcWaN8364aN8Pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+zLSDTB; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+zLSDTB" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48439feca17so2818995f8f.1 for ; Mon, 28 Sep 2026 22:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790660050; x=1791264850; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vDrRpA1W/7JjCEY/lfrVQceoo3M5nHbNKEhFmkg5umg=; b=g+zLSDTBN5PBcQHF5j5AAGj8sobOayPMm/lPnpU7fFtjmd3yNMI9nSQHvybIYKg/n+ GnGtfnaSbNuUbTmkxDnLFRqu09paoQmpeHA9gNMpY/dnIiFV2aTWuyoV1ec/eekRx1+w +cFWuPIJoHLHgXUoyu2mRuVcCvIFCsfVnszBEcOfx33IZmpH8ZPyNBUgz3kKmqunn1Tg uKWjYgPIBuXLK+Cs/AqKE+2lqdLlelH0tOcKaTzbAFTopW7ebyce/4Sp1LnRuciwb8ov zrfKTEZqkXuAiXYdLJdO1RPcMxP+iSEhL6TFXWJxtc9mGiJT6dynqKgOppieq46c7rex nwaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790660050; x=1791264850; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vDrRpA1W/7JjCEY/lfrVQceoo3M5nHbNKEhFmkg5umg=; b=Ue/3DaVzQMO/Mmbdz1hpaGfYgJS4Lbbsl4quTxzLePxCAStddYsBjnrtZuauln6SLv uvNYihR3BvQFuevHt7XP2P/9tGm5jkcSKhl6yb/HKbKssiUh8l7+Hr0wv1lkwXBYxd3D +YVsr1d9gh/9NogIed4IhfQekj/0ZOvE+WUol2nTf8aFhHzS/PZ7ZpOQwKmKDTtO1vGx 4NFdxqZjYBxR5yEsIMO+O/yflI5d+D69imQwbCkYL1TOSHemLf2+1ePpUALT9inBoX4C 9cFypXPigybSFe7J1YolOO+SVtkB+Mrg1dQ1fPqkKklwiQDiGh/mCu4JLVqdaeH6oV/c coQA== X-Forwarded-Encrypted: i=1; AKwUvBzpZ5G921rnJtGBmDf5PZYal9TDGzUKkBZiPA6C5iPTnXLZP9XsXTzcxFFu26ZVu+3VIDMpZlYr1CdHn0Y=@vger.kernel.org X-Gm-Message-State: AFq9FYL0r/+YiExKN3q1DVLmYQrNIvds3ZW+sLiJKIolSSDV/Zi6lbA3 sKt6cs5YD8fSmudWul1uOZbtayfSNN0Bd47k0vc9/uJVmQYKy85m5FYDX2lGKNYq X-Gm-Gg: AYBFou3zHVrXprbbpNhnWpZZr+2+DHnF43KL0Ky8VPRR0NoJAClwMFGfmPesh5tUuTF sQTBymqg8WJIwQadFaXdKywxuUR9O0rQyzYsudRnRBundyRr/1Yg11MWcf0tdTMmTqiJ5Xn8Bnh uSuw43oUS9tEauSLrhsDPdOuz5tTtDn4+Rz9UwDvowHP+UXceFWd4rLsVCM1byx/TuLhNZfG6St iFTCme81xGVjwJbbylSNRbEEZyY8tDbNPohNdV5nEZBX2Gbb7Ke6hFn6Ko976v/E78q1PVNbMbX uDdrWiNIyE5ZZECs3Ys3CyO61nsimk+WAE0nsNF/h/A4/yrdB5zxPb2YpoipwgyJz6b22FHjdAE 0YhOhf5MaRXQsH9KtZDf64JETM58K61/Dxka3Y9VdJlvlASgoAGpnwe38rjiCy1+Ypshm5C6vpW 724CVBJbL5qosZ4+jqouzN/qSeQoKWZo26K9sFr/EbAuHLRrGvf7m1sWCq1tjyYzwprIep4x/yG JVXxUt3dpl7nKlzv1Q0kRbxF9bHZoCppXVvu/wcfSVOjVCBRgy85spdFodWiALZ56QDqNRdPn2Z R5nLSuB3xxRIzv+5ZiLA/XX7GgSitg1oZQHpWwZjtvNHXYb3T8VHiDfgk0Udkte9USTaLXgX/bU = X-Received: by 2002:a5d:5e83:0:b0:488:84bf:eedf with SMTP id ffacd0b85a97d-48884bff147mr15033151f8f.48.1790660049555; Mon, 28 Sep 2026 22:34:09 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-9c32-f801-0451-cc94-d3ca-f56b.310.pool.telefonica.de. [2a02:3100:9c32:f801:451:cc94:d3ca:f56b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48af506fdc1sm1047634f8f.21.2026.09.28.22.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 22:34:08 -0700 (PDT) Date: Tue, 29 Sep 2026 07:34:06 +0200 From: Karl Mehltretter To: Jeremy Kerr Cc: Matt Johnston , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, Geert Uytterhoeven , Brendan Higgins , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: mctp: Make KUnit tests depend on flow support Message-ID: References: <20260925192510.93840-1-kmehltretter@gmail.com> <20260928205352.30502-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 29, 2026 at 09:02:23AM +0100, Jeremy Kerr wrote: > > This keeps the full flow-test coverage: the suite is available only > > when flow support is enabled, for example by the I2C transport. > > Hardware transports are typically not enabled for kunit test kernels. > > Are you attempting to fix an actual problem you're encountering? What's > the aim with this change? > Hi Jeremy, It's no real-world MCTP workload bug. This came from a similar issue in my 842 KUnit patch: the test selected the decompressor. Geert pointed out that tests should not silently enable otherwise-unused code: https://lore.kernel.org/r/CAMuHMdVcZ5cV4-HrjLYfFKh6UshiVxq5eXCNyp0Z1k_SMAvF5g@mail.gmail.com/ My goal is to keep KUNIT_ALL_TESTS from pulling in otherwise-unused production code. An explicit opt-in could preserve the coverage, following CRC_ENABLE_ALL_FOR_KUNIT and CRYPTO_LIB_ENABLE_ALL_FOR_KUNIT: - MCTP_ENABLE_ALL_FOR_KUNIT depends on KUNIT=y and MCTP=y - it selects MCTP_FLOWS - all_tests.config enables it - MCTP_TEST depends on MCTP_FLOWS This keeps KUNIT_ALL_TESTS from enabling optional flow code, while the explicit kunit.py run --alltests profile opts into it and retains full flow coverage without requiring a hardware transport. Would that approach work for you? Karl