mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	 Jonathan Hunter <jonathanh@nvidia.com>,
	mfd@lists.linux.dev, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	 linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 2/2] dt-bindings: sound: tegra-ahub: Convert to json-schema
Date: Tue, 29 Sep 2026 13:44:54 +0200	[thread overview]
Message-ID: <arugF4OhAMqzGith@orome> (raw)
In-Reply-To: <d5ebde9e-29be-47ab-b74e-63a6bda079a4@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

On Mon, Sep 28, 2026 at 08:23:45PM +0100, Mark Brown wrote:
> On Mon, Sep 28, 2026 at 06:24:41PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Convert Tegra AHUB bindings from the free-form text format to
> > json-schema.
> 
> > -- compatible : For Tegra30, must contain "nvidia,tegra30-ahub".  For Tegra114,
> > -  must contain "nvidia,tegra114-ahub".  For Tegra124, must contain
> > -  "nvidia,tegra124-ahub".  Otherwise, must contain "nvidia,<chip>-ahub",
> > -  plus at least one of the above, where <chip> is tegra132.
> 
> This documents fallbacks...
> 
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nvidia,tegra30-ahub
> > +      - nvidia,tegra114-ahub
> > +      - nvidia,tegra124-ahub
> 
> ...but this does not.

In device tree we never used nvidia,tegra132-ahub, but I guess it's
technically necessary, so I'll add that combination here, exactly as
described in the original bindings, and fix up the device tree to use
that instead.

> 
> > +  resets:
> > +    minItems: 11
> > +    maxItems: 21
> > +
> > +  reset-names:
> > +    minItems: 11
> > +    maxItems: 21
> 
> Ideally there'd be per-SoC constraints but meh.

They are there, further down below, though maybe somewhat hidden. The
per-SoC constraints define the exact items that need to go into each of
these. Though I guess I could expand a bit more and narrow down the
minItems and maxItems for each compatible.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-09-29 11:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 16:24 [PATCH 0/2] arm64: tegra: Fix DT validation issues for Tegra132 Thierry Reding
2026-09-28 16:24 ` [PATCH 1/2] dt-bindings: mfd: as3722: Convert to json-schema Thierry Reding
2026-09-28 21:41   ` Rob Herring
2026-09-28 16:24 ` [PATCH 2/2] dt-bindings: sound: tegra-ahub: " Thierry Reding
2026-09-28 16:38   ` Mark Brown
2026-09-28 19:23   ` Mark Brown
2026-09-29 11:44     ` Thierry Reding [this message]
2026-09-28 21:46   ` Rob Herring
2026-09-29 11:21     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arugF4OhAMqzGith@orome \
    --to=thierry.reding@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®