From: Petr Mladek <pmladek@suse.com>
To: Wang Wensheng <wsw9603@163.com>
Cc: rostedt@goodmis.org, john.ogness@linutronix.de,
senozhatsky@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] printk_ringbuffer: Avoid needless read of prb_desc
Date: Tue, 29 Sep 2026 17:09:58 +0200 [thread overview]
Message-ID: <arvUxki9K5mkomoP@pathway.suse.cz> (raw)
In-Reply-To: <20260926094502.251204-1-wsw9603@163.com>
On Sat 2026-09-26 17:45:02, Wang Wensheng wrote:
> Since commit f244b4dc53e5 ("printk: ringbuffer: Improve prb_next_seq()
> performance"), desc_read() allows @desc_out to be NULL. We can drop the
> local `desc` variable in desc_reopen_last() and prb_first_seq(). Also
> update the comment for desc_read().
>
> v1->v2:
> Update the comment suggested by John.
>
> Signed-off-by: Wang Wensheng <wsw9603@163.com>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
JFYI, the patch has been comitted into printk/linux.git,
branch for-7.4.
Best Regards,
Petr
prev parent reply other threads:[~2026-09-29 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 9:45 Wang Wensheng
2026-09-29 15:09 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arvUxki9K5mkomoP@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=wsw9603@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®