From: Drew Fustini <fustini@kernel.org>
To: Aamir Ahmed <elb12345@hotmail.co.uk>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Drew Fustini <dfustini@oss.tenstorrent.com>,
Joel Stanley <jms@oss.tenstorrent.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>,
Kees Cook <kees@kernel.org>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] clk: tenstorrent: Assign .num before accessing .hws
Date: Tue, 29 Sep 2026 12:55:22 -0700 [thread overview]
Message-ID: <arwXqtNq63F9D9M6@x1> (raw)
In-Reply-To: <arSHQglLv0FfAmiw@x1>
On Wed, Sep 23, 2026 at 07:13:22PM -0700, Drew Fustini wrote:
> On Thu, Sep 10, 2026 at 01:47:31AM +0100, Aamir Ahmed wrote:
> > On Tue, Sep 08, 2026 at 11:56:12AM +0200, Gustavo A. R. Silva wrote:
> > > Looks like variable num_clks can be removed entirely, and just do:
> > >
> > > clk_data->num = data->num;
> >
> > Yes - it is only read once and data is const.
> >
> > Thanks for reviewing, and thanks Anirudh for testing. For the redundant
> > variable, since this has a stable Cc, perhaps we can keep the diff
> > minimal here and I can send the cleanup as a follow-up once it lands?
> >
> > Kind Regards
> >
> > Aamir A.
>
> Thanks for sending the patch.
>
> I would prefer a v2 with this change in order to avoid a trivial patch
> later. We are still in the process of upstreaming support for the
> Atlantis platform, so there are no users yet that would be affected by
> this issue.
Applied to tenstorrent-clk-for-next with that fixup so there is no need
for a v2:
da9f1312b06e clk: tenstorrent: Assign .num before accessing .hws
Thanks,
Drew
next prev parent reply other threads:[~2026-09-29 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 20:48 Aamir Ahmed
2026-09-08 2:56 ` Gustavo A. R. Silva
2026-09-10 0:47 ` Aamir Ahmed
2026-09-24 2:13 ` Drew Fustini
2026-09-29 19:55 ` Drew Fustini [this message]
2026-09-09 15:02 ` Anirudh Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arwXqtNq63F9D9M6@x1 \
--to=fustini@kernel.org \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=bmasney+clk@redhat.com \
--cc=dfustini@oss.tenstorrent.com \
--cc=elb12345@hotmail.co.uk \
--cc=gustavo@embeddedor.com \
--cc=jbrunet+clk@baylibre.com \
--cc=jms@oss.tenstorrent.com \
--cc=kees@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®