From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA3F91FFC48; Wed, 30 Sep 2026 08:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790755856; cv=none; b=XcU5XOvIfYASsiZ194x+1O9PbHOZLh/WsraZegLGE9k4WGtcneYSC8adt4HXPh3e+9J0fQwJoCQwp/D4cr9FeY0HA+kiT+Kk0HyI3G9VLYCf3xXXjRnh0h/uqv39mAwFuFONfRUdafX++TF/MVvtqNFc7HmFd9iscsBOIYIVUSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790755856; c=relaxed/simple; bh=hHrhtuPfz8cY4nqqaBD39+J7EB83alLmq4ViBtLbrO8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q7petyLCja3kB6zLtgkvo2MfNShODaReX7FhJA/ZMkbT/HzXR3q6PTIDE62JHNQSG/kGP8Ji5vyMilYgw7qrkYGZuF3cdDnFeh+bDEbnOA+FPdGLRGni0nSWOAmrP/l3kWSi7LwEbMr2TocP6Uh7ybM2/hk9MWPY74aWLoWyfL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Y4jcoMtD; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Y4jcoMtD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790755854; x=1822291854; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=hHrhtuPfz8cY4nqqaBD39+J7EB83alLmq4ViBtLbrO8=; b=Y4jcoMtDtDjEQcyPAktid7zkRDWDdf0mDWRN6YZf5yQFty9BfoUBsgOE +msgJwO2Ran5OzK+v9dJJQ5FJIL2F30zoh/3u/3h7/Ktzfgil5oRuhgw3 8j5sjEa44vNMgSzEQtKxi8DFPvUEOWf9eLpcT6J2wgCl2O93DkC78Co7+ GoFX64yXaavUMUpdhnuRLkKOhxWFnmgQMTNObEkW1byKjGfkIaVscJFZL PL9oR2jsrqNmzQjIK0i3r+Z9SKM8d4tcPySYeE72N8TFyEZiWl5w24q4D oGaL8ozRq27aJyEfGFA4I1rWYpfsUQvtetIwwYdX6b701hWxfuz+9HDil g==; X-CSE-ConnectionGUID: OJmNQrXlRR+TCerOmHwZcg== X-CSE-MsgGUID: 6YXGWqebTEmRaaE6uVZckw== X-IronPort-AV: E=McAfee;i="6800,10657,11920"; a="102859678" X-IronPort-AV: E=Sophos;i="6.27,132,1787036400"; d="scan'208";a="102859678" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2026 01:10:54 -0700 X-CSE-ConnectionGUID: scJ8q8ftRLOx8ItKcO1Q7Q== X-CSE-MsgGUID: C26PpsinTuC9GIobD8UMYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,132,1787036400"; d="scan'208";a="278966761" Received: from spandruv-desk1.amr.corp.intel.com (HELO localhost) ([10.245.245.137]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2026 01:10:50 -0700 Date: Wed, 30 Sep 2026 11:10:48 +0300 From: Andy Shevchenko To: Sakari Ailus Cc: Andy Shevchenko , Bartosz Golaszewski , Mika Westerberg , Bartosz Golaszewski , Linus Walleij , Andy Shevchenko , Peter Tyser , Lixu Zhang , Mika Westerberg , Israel Cepeda , Hans de Goede , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Alan Borzeszkowski Subject: Re: [PATCH RFC] gpio: move intel drivers into their own directory Message-ID: References: <20260928123446.GH106095@black.igk.intel.com> <8fa77d7021ddf66f344c139d3bbeebcdb47ebfa8.camel@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Sep 30, 2026 at 11:08:07AM +0300, Andy Shevchenko wrote: > On Tue, Sep 29, 2026 at 10:53:40PM +0300, Sakari Ailus wrote: > > On Tue, Sep 29, 2026 at 06:09:20PM +0300, Andy Shevchenko wrote: > > > On Tue, Sep 29, 2026 at 5:05 PM Bartosz Golaszewski wrote: > > > > On Tue, Sep 29, 2026 at 3:31 PM Andy Shevchenko > > > > wrote: ... > > > > > > > in any case my series is blocked as I have not seen > > > > > > > a consensus on what to do. Or do we? Bart, Sakari? > > > > > > > > > > > > If I didn't make myself clear: I would love it if there was a single source > > > > > > of intel GPIO pull-requests (most likely Andy) for *all* intel GPIO drivers > > > > > > even if they have additional reviewers. I'd also love for them to live in > > > > > > a single subdirectory at drivers/gpio/intel/. Otherwise, it's still chaos like > > > > > > right now, just worse. > > > > > > > > > > > > This is in line with pinctrl vendor directories. I also don't see a reason for > > > > > > moving Kconfig options into their own vendor submenus if we keep the top-level > > > > > > entries sorted by driver type. > > > > > > > > > > So, as of now it doesn't seem like an agreement among all parties. My > > > > > opinion is that it's good to have PMIC be separated from the other > > > > > code, although I don't know if the camera PMIC GPIO driver that is > > > > > used with IPUx is good to go under the intel/pmic subfolder. I also > > > > > believe that camera related drivers are the best to be handled by the > > > > > media tree (as it's done, exempli gratia, for int3472). > > > > > > > > > > At the end of the day you will have a single PR from me, but it won't > > > > > include camera stuff unless Sakari agrees to send a PR to me (which I > > > > > think won't be the case). > > > > That'd work, sure, but there are often dependencies between all three USBIO > > related drivers (main, I²C and GPIO) so they'll all go typically via usb > > tree in that case. Having them all be merged via the media tree would > > require more discussions. > > > > > > I thought we agreed usbio would be moved out of drivers/gpio/ and into > > > > media? That leaves intel/pmic as the only subdirectory IIUC. > > > > > > Hmm... I cited the int3472 MAINTAINERS record to point exactly on the > > > variant where it's left under drivers/gpio. Also IIUC Hans' opinion is > > > that GPIO drivers even being USB GPIO expanders for camera are still > > > GPIOs. > > > > Indeed. > > So as I see now there is a consensus that > 1) it's good to have Intel related GPIO drivers to be in 'intel' folder; > 2) the USB GPIO drivers are still a GPIO and should reside under drivers/gpio/ (somewhere beneath that, subfolder or not). > > We do not have a consensus on: > 1) PMIC separation to the 'intel/pmic' subfolder; > 2) USB GPIO route for patches (with them still be somewhere under drivers/gpio/). > > Unanswered question: > 1) do we need to consider gpio-tps68470 (camera PMIC on Intel HW) as part of > 'intel/pmic' or even 'intel' in general? Currently the Intel HW is the only > user of it. > > P.S. It seems a big deal to move the drivers from one folder to another :-) Ah, and on top there is the request from Bart to handle all Intel related ones at once. Personally I would not stick with that, but I'm not a GPIOLIB maintainer. -- With Best Regards, Andy Shevchenko