From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
Cc: hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailios@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v5 2/2] staging: media: atomisp: Remove dbg_level and dbg_func module parameters
Date: Wed, 30 Sep 2026 12:18:43 +0300 [thread overview]
Message-ID: <arzT86qPj-GOFRP-@ashevche-desk.local> (raw)
In-Reply-To: <20260722054615.21492-3-prajvalchaudhari733@gmail.com>
On Wed, Jul 22, 2026 at 11:16:15AM +0530, Prajval Chaudhary wrote:
> Remove the 'dbg_level' and 'dbg_func' module parameters to align the
> driver's debug logging with standard Linux kernel printk infrastructure.
>
> Previously:
> - 'dbg_level' controlled trace verbosity level (default 0, up to 9).
> - 'dbg_func' selected whether CSS trace outputs routed to printk (1)
> or remained disabled/unrouted (0).
>
> Since module-level custom parameters duplicate modern dynamic debug and
> printk capabilities, remove them and filter trace messages in
> ia_css_debug_vdtrace() to IA_CSS_DEBUG_WARNING or lower.
...
> unsigned int ia_css_debug_get_dtrace_level(void)
> {
> - return dbg_level;
> + return 0;
> }
I believe this changes the flexibility of the tracing. But like I said, the
whole infrastructure should be switched to use trace events and trace points.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-30 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YOUR_ANDY_EMAIL_MESSAGE_ID_HERE>
2026-07-22 5:46 ` [PATCH v5 0/2] This series cleans up unused module parameters from the atomisp driver Prajval Chaudhary
2026-07-22 5:46 ` [PATCH v5 1/2] staging: media: atomisp: Remove pad_w and pad_h module parameters Prajval Chaudhary
2026-07-22 5:46 ` [PATCH v5 2/2] staging: media: atomisp: Remove dbg_level and dbg_func " Prajval Chaudhary
2026-09-30 9:18 ` Andy Shevchenko [this message]
2026-08-11 14:02 ` [PATCH v5 0/2] This series cleans up unused module parameters from the atomisp driver Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arzT86qPj-GOFRP-@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=prajvalchaudhari733@gmail.com \
--cc=sakari.ailios@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®