From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 583583B6BF0; Wed, 30 Sep 2026 10:23:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790763791; cv=none; b=C1ktaYx8mr7q95N082s1xwypMAAxlKXUaAKO/wQ4qU/ZsQiUDaP19TMveaFd6ZbuuWRzQw+09GU89xakAuwuzVYJJddEJuWbtVFsr2Bh+vmOGxqHwD5b7a6kgT9SYwN1uLfwl1jEC6VgHQ8nN/QcfW7xa9Aorwnkb7+HenU6EPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790763791; c=relaxed/simple; bh=Ac9CVGOrU6oXqL6GVn2GyjRWBzUZlH+PpKQIsO0i+g0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HTMClG4aw0hmcTv3ouAfF2TEsMsi9l9R4ZkZ51DofR27sLHsYht9/YUvW6ugroy4gXc1+OQJ+0tODBcj+npA8sUbq5zPek/DXESjpc5p5ckJzyrPS7cHkYGrG3IC6xH7gsVa1DkGx5UeGRuD68r0tEX30ro7E8TPIpCv47/vuX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lHeN8bl4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lHeN8bl4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EE551F000FF; Wed, 30 Sep 2026 10:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790763789; bh=Y6/eisC/1PFb58SA29sI1vLKdk/wVao3FROKDUJrtpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=lHeN8bl4qsZssVq0G+AKebLkMTNz5dsor1PkFzGDB+Fo2ksKyhPNcWDNf3c1oW8AY SXRyEup0Z6PhB1unC/Za3hEb8fCraiDSrAIdgUk5f7mOMUpKb7UQ2iuKLBPVFdWbkO Xd2yb175oTanKHzoLQk/Xfu3cX3pq2QP1qHe06uMrJOkxAdvC/01OMdzpZEu16E5Qv JAlnpQPUgYbezTQU6fB+sTFDdNApoezixWJhLASufOfh3x5Ve7/mBGmDFSKXlU6sJE +ldKbJ4qgrqVSuFdOuRtS92TxcnbufO1EcWK/uC0jBU1NaeZBm5yeRjgsixw9aKjRZ Eg3tKpKpJDWlw== Date: Wed, 30 Sep 2026 12:23:07 +0200 From: Thierry Reding To: Svyatoslav Ryhel Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Hunter , Mikko Perttunen , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 6/6] drm/panel: Add Hitachi TX10D07VM0BAA and LG LH400WV3-SD04 MIPI DBI panel driver Message-ID: References: <20260930070535.47130-1-clamor95@gmail.com> <20260930070535.47130-7-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c2npe4egdsdkxc2s" Content-Disposition: inline In-Reply-To: --c2npe4egdsdkxc2s Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 6/6] drm/panel: Add Hitachi TX10D07VM0BAA and LG LH400WV3-SD04 MIPI DBI panel driver MIME-Version: 1.0 On Wed, Sep 30, 2026 at 12:08:41PM +0300, Svyatoslav Ryhel wrote: > =D1=81=D1=80, 30 =D0=B2=D0=B5=D1=80. 2026=E2=80=AF=D1=80. =D0=BE 12:02 Th= ierry Reding =D0=BF=D0=B8=D1=88=D0=B5: > > On Wed, Sep 30, 2026 at 10:05:35AM +0300, Svyatoslav Ryhel wrote: [...] > > > +static const struct of_device_id panel_dbi_of_match[] =3D { > > > + { .compatible =3D "hit,tx10d07vm0baa", .data =3D (void *)PANEL_= DBI_TX10D07VM0BAA }, > > > + { .compatible =3D "lg,lh400wv3-sd04", .data =3D (void *)PANEL_D= BI_LH400WV3 }, > > > > Why the detour through that PANEL_DB_* enum? You could just pass the > > panel funcs pointers directly via .data here. > > >=20 > Passing API/OPS via .data is discouraged. No it's not. We do it all the time. > > Also, looking at the enable/disable sequences these are in fact two > > different drivers, with the only commonality being that they happen to > > be used in the same device. Rolling them both into one driver seems a > > bit odd. >=20 > I did this to simplify maintainance. Both panels are used in the LG > Optimus 2X. My assumption is that LG switched one to another at some > point, hence they share same timings, controls and supplies, but > differ in en/disable sequence. Additionally, these are the the only > DBI Type B-only panels in the kernel, from what I can see. That's just one more reason to put them into more of a generic driver, which would allow people to find it and extend/improve it as needed. > > If you really want to avoid duplication, maybe they should go > > into some kind of "simple" or "generic" DBI driver. >=20 > DBI Type B is not well supported in the kernel. Well, you always start somewhere. Thierry --c2npe4egdsdkxc2s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmq84wgACgkQ3SOs138+ s6Eiuw//RQ2fm/9EQCbJc7rzzjSmpYsrALrOL8ogrNgRr+Us7Js++rkpBy77jMCa 90Qnk6xN1CIf9BhJTiguaDmm5iYpvItlJttFThldrtaVCWR0dlS5YhTDgabxCcXh CGvcXuGxPZfmx5/+IYpBkO48k83Czq+9CHDjL33IVSNmOXikAHLC9YeetQEky5vT p8AANLuVKSig8r6ZpamwRiiiPDNhaQP2ohSJ58uaK3e0224iYTm7AYfEj6VZPKdG yzO/ZrgFtpveqy6/XuY6h9GP2uF+lIE1ZAw1RseBYGuQe3/fROaZcCo+48T3h3cA EKVOOGEFkbZVJtqojDA9vFrZyptANBNtFnB6TtNV4252NoMwkVpRs6zgcMO0F8k4 VBvzfEVE8Q8O5YD7Alugjsg5bdu+AmyxB9LnnqbvAIDwjPpbjGCo7b0slLaNxpq4 XMuzqsM8l5YvLFzgK3APfk13aBRbZoraA1NxE0pDOiJuz2jU2GQM93ApmReILD3a wdC6598g1AkPaxNOSe/NIbe/uSg8a5AGE17AL7o5QJsbdgC58eHte8NsrplzK3h8 HXFCnZIhsl9F6PtqtEccus3qYk0kZENOYgEjwkIHVlMHVAUDOufngzwrX+QERknV 7mWpdUkxp9lUlmS5BXUcZRb1PR6e5ucdggcIjv6SFJYsWmdFf2Q= =5XM7 -----END PGP SIGNATURE----- --c2npe4egdsdkxc2s--