mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: vkoul@kernel.org
Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
	peter.ujfalusi@linux.intel.com, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Allow SoundWire devices to communicate during remove
Date: Wed, 14 Oct 2026 17:27:41 +0100	[thread overview]
Message-ID: <as+tfcouMGOL9cZ1@opensource.cirrus.com> (raw)
In-Reply-To: <20261012105540.1686405-1-ckeepax@opensource.cirrus.com>

On Mon, Oct 12, 2026 at 11:55:37AM +0100, Charles Keepax wrote:
> Currently on Intel systems SoundWire drivers can't communicate with the
> device during driver removal. This is primarily because the IRQs are
> disabled before the driver remove callback is run. The result of this is
> such transactions timeout causing a) a lot of errors in the log and b)
> driver remove to take a very long time.
> 
> This issue affects cs42l43 and cs42l45, primarily due to both using
> regmap IRQ.
> 
>  soundwire_intel soundwire_intel.link.0: IO transfer timed out, cmd 3 device 6 addr 5d len 1
>  soundwire sdw-master-0-0: trf on Slave 6 failed:-110 write addr 5d count 0
>  sdca_class sdw:0:0:01fa:4245:01: Failed to sync masks in 5d
> 
> As regmap IRQ is torn down it will mask the interrupts that are
> removed. However, there are many valid reasons a driver might want
> communicate with the device during removal, others would include
> disabling jack detection, putting the device into the lowest possible
> power state to save power, etc.
> 
> This patch set attempts to address this problem trying to locate the
> reason interrupts are disabled, fixing that and then leaving the IRQs
> enabled for the remove callback.

Apologies, but I might have come up with a slightly better fix
here. Please don't merge this version and I will report back in a
few days.

Thanks,
Charles

      parent reply	other threads:[~2026-10-14 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 10:55 Charles Keepax
2026-10-12 10:55 ` [PATCH v3 1/3] soundwire: bus: Don't unassign dev_num before unregistering device Charles Keepax
2026-10-12 10:55 ` [PATCH v3 2/3] soundwire: bus: Expose a helper to remove devices from the bus Charles Keepax
2026-10-12 10:55 ` [PATCH v3 3/3] soundwire: intel_auxdevice: Don't disable IRQs before removing children Charles Keepax
2026-10-14 16:27 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as+tfcouMGOL9cZ1@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®