mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Guillaume Tucker <gtucker@gtucker.io>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Mallesh Koujalagi" <mallesh.koujalagi@intel.com>,
	"Badal Nilawar" <badal.nilawar@intel.com>,
	"Michal Wajdeczko" <michal.wajdeczko@intel.com>,
	"Riana Tauro" <riana.tauro@intel.com>,
	"Stuart Summers" <stuart.summers@intel.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/xe/log: fix documentation title levels
Date: Mon, 12 Oct 2026 15:46:08 -0400	[thread overview]
Message-ID: <as05AF81CNjbCEas@intel.com> (raw)
In-Reply-To: <2320050536ca29afe69ecd163eb974a40df571fc.1791740369.git.gtucker@gtucker.io>

On Sun, Oct 11, 2026 at 07:46:53PM +0200, Guillaume Tucker wrote:
> Fix an htmldocs build error in the gpu/xe section by moving all the
> titles one level higher in the Xe SIGID page to keep a consistent
> hierarchy.  This is the error message:
> 
>     Documentation/gpu/xe/xe_sigid.rst:10: (SEVERE/4) Title level inconsistent:
> 
> All the other pages in the xe section use <h2> titles so follow the
> same convention here as well.

it looks like we have more stuff to fix in the xe_migrate.c still...

thanks for this patch.
pushed to drm-xe-next

> 
> Signed-off-by: Guillaume Tucker <gtucker@gtucker.io>
> ---
>  drivers/gpu/drm/xe/abi/xe_sigid_abi.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/abi/xe_sigid_abi.h b/drivers/gpu/drm/xe/abi/xe_sigid_abi.h
> index 2f3440505f69..277b15fce9cc 100644
> --- a/drivers/gpu/drm/xe/abi/xe_sigid_abi.h
> +++ b/drivers/gpu/drm/xe/abi/xe_sigid_abi.h
> @@ -10,14 +10,14 @@
>   * DOC: Xe Error Signatures (SIGID)
>   *
>   * What SIGID stands for
> - * ---------------------
> + * =====================
>   *
>   * SIGID is short for *Signature Identifier*. It is a small, stable integer
>   * that names one of the *recognised fault sites* -- nothing more. It is the
>   * primary handle used for triage and maps directly to a specific report site.
>   *
>   * Numbering
> - * ---------
> + * =========
>   *
>   * SIGIDs are a single flat list numbered sequentially within the assigned range,
>   * in the order the fault sites were introduced. Values are stable: once assigned
> @@ -25,7 +25,7 @@
>   * SIGID value is deprecated in place, never re-purposed.
>   *
>   * Why this exists
> - * ---------------
> + * ===============
>   *
>   * Today the driver reports faults with ad-hoc ``xe_err()`` / ``xe_gt_err()``
>   * strings that have no stable shape. That is fine for a human reading dmesg,
> @@ -37,7 +37,7 @@
>   * firmware versions, and (eventually) across other Intel devices in a node.
>   *
>   * What a SIGID is not
> - * -------------------
> + * ===================
>   *
>   * SIGID deliberately does not encode the detailed reason or the outcome. Those
>   * are carried alongside it::
> @@ -51,7 +51,7 @@
>   * different severities depending on the instance and the recovery taken.
>   *
>   * When to use SIGID logging
> - * -------------------------
> + * =========================
>   *
>   * The xe_log_*() helpers are for these recognised fault sites only --
>   * important, operator-relevant faults and events. The driver's only job is to
> @@ -63,7 +63,7 @@
>   * those that correspond to a published fault site.
>   *
>   * SIGID log output (dmesg vs. the machine record)
> - * -----------------------------------------------
> + * ===============================================
>   *
>   * The dmesg line stays close to a normal xe error message so it remains
>   * readable for admins; the only stable, machine-matchable token on it is
> @@ -74,7 +74,7 @@
>   * carrying the same SIGID (generation is a planned follow-up).
>   *
>   * How to pick a SIGID (the uniqueness rule)
> - * -----------------------------------------
> + * =========================================
>   *
>   * Pick per *report site*, not per incident. Each site emits the single most
>   * specific recognised SIGID *for that site* -- so the question is never
> @@ -95,7 +95,7 @@
>   * after making significant changes to the site that emits this SIGID.
>   *
>   * Scope: software vs hardware emitted signatures
> - * ----------------------------------------------
> + * ==============================================
>   *
>   * Some SIGID represents fault sites that the *driver itself* detects and
>   * reports from the software POV: probe abort, wedged, survivability, driver-
> -- 
> 2.47.3
> 

      reply	other threads:[~2026-10-12 19:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 17:46 Guillaume Tucker
2026-10-12 19:46 ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as05AF81CNjbCEas@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gtucker@gtucker.io \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=stuart.summers@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®