Re: [PATCH 2/3] drm/bridge: simple-bridge: Add Toradex RGB to VGA DAC bridge

[Frank Li <Frank.li@oss.nxp.com>]

On Mon, Oct 12, 2026 at 04:25:24AM -0300, Leonardo Costa wrote:
> From: Leonardo Costa <leonardo.costa@toradex.com>
>
> The VGA bridge on Apalis iMX6 consists of a simple resistor ladder that
> converts a digital 16-bit RGB signal to VGA. The VGA output is gated by
> an active-low data-enable signal.
>
> Signed-off-by: Leonardo Costa <leonardo.costa@toradex.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/gpu/drm/bridge/simple-bridge.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index 3fba7002322e..3f88fcdfa214 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -253,6 +253,10 @@ static const struct drm_bridge_timings ti_ths8135_bridge_timings = {
>  	.hold_time_ps = 500,
>  };
>
> +static const struct drm_bridge_timings toradex_apalis_imx6_vga_dac_timings = {
> +	.input_bus_flags = DRM_BUS_FLAG_DE_LOW,
> +};
> +
>  static const struct of_device_id simple_bridge_match[] = {
>  	{
>  		.compatible = "dumb-vga-dac",
> @@ -312,6 +316,12 @@ static const struct of_device_id simple_bridge_match[] = {
>  			.timings = &ti_ths8134_bridge_timings,
>  			.connector_type = DRM_MODE_CONNECTOR_VGA,
>  		},
> +	}, {
> +		.compatible = "toradex,apalis-imx6-vga-dac",
> +		.data = &(const struct simple_bridge_info) {
> +			.timings = &toradex_apalis_imx6_vga_dac_timings,
> +			.connector_type = DRM_MODE_CONNECTOR_VGA,
> +		},
>  	},
>  	{},
>  };
>
> --
> 2.43.0
>
>