From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FB274DEC1E for ; Mon, 12 Oct 2026 20:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791837814; cv=none; b=t0OH/kJ934gNVlW5A1XeiRpUJLH/SUo8/Z5F7rt8bVsQHekMRfSnhPjV+Fmv+KczeUHftM4P+k+m5DnJI6AjUJtRsquFlzqIUvBKBzZnDm+UBgCx4fZlpX6FkLHOG4Cw5QfXv21vfdjKDkmqztFeJyz7cyXxQA8SWUInjUJioF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791837814; c=relaxed/simple; bh=SWVAfflsvR7uwsFRFLUgJMbObCSKiB2/FdyOcDm66zE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oqhUKCIG5shi3Vxz3Q3u+t1T/o63SEozbew/yQUGN2R1JxE0H+g+u3/LmpWP7A8RgWdzNBXCVwzHOtYcYqGVTNCpAN+6AprFwmH0bJeCW+ateprk1cbLxrcolL7N6beauGKiwgO+F7PCrKN1akNUY3oZ+3CW7RpFZZ8aCTVgtw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=dGLzxKc1; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="dGLzxKc1" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4a1698ea378so18590455e9.2 for ; Mon, 12 Oct 2026 13:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791837811; x=1792442611; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XK+SEB+e/GS3thSnPWg9ZaAuDfBuOx8piTMr3Esm78A=; b=dGLzxKc1JirYvojo0RObX1aFxRnkvO/Alo1BeCnN6QbXoLPOqWh+/mCb+wi7IgUu05 StF00gmsypnUd7iKBzYy/HE4RrxAt9r8KFAbb7X+kmKU0I8VTn1h9giWAsfeMXcjOtjA R9KpNp8rIV9zXnFzlaqUTzdMUsUMyYk/KfZOJbuTH4H7zJAy+xo053cyKY2nA9MB8YbT 2ougQHSFyOg1LsUTfVlJDNNpk7Lyx2aYSX+c5lU2Yh68Z/BbkOM+ShopVC+D+bdXKFrF pR3ZIj9zYISTReJE/dNgp4MnImaINnSl80R619cqP5PVDejLOhtB/UaqZBoTV69FbkWf pbOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791837811; x=1792442611; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XK+SEB+e/GS3thSnPWg9ZaAuDfBuOx8piTMr3Esm78A=; b=1W1eh0sIKTpNb7SCRToF0Ijjo+kQmmORnHE9Vt1yakjMe6qayxWjU07HuDrN/WIsGf fJjBUe9tG1yIkWgfnz9EaqnYZFMEXRfWxLEfVKDhei4z/i2pNFmZi/UYSeH74dJ6AdWq csWZbX4xAxXgPgxsWw19M4UuhEWub2pvSUHOrgZRB+JJPe94zlIupBBfMVIpdn7uAjpf ygDC2708dowO62AbWnl35tn5A9sQhMj4kJKi8uaWGi3YBx9xbkVWnOCv4JWuU2KKzMzn eJSFUYQkppAuOoGuDiZBuVCwwjVznMetrfBpVieo40XlUhN/8a0UTvDNUmaCYvGtIIqc rH3w== X-Forwarded-Encrypted: i=1; AKwUvBzYo7YhrRm8XOIWK4PrVVMmiMmMTHLl3HU9Lf++mIlEFDwQHgpc4ULwb26AsLHp2Ejy8okQ/1NDBUb0exE=@vger.kernel.org X-Gm-Message-State: AFq9FYKKcGGiL401KpEAGa0vwiOiU8O0aKlCceyv5IKaZnOx6fmXQKWu 9FFkuHsbn7olgSF0Nc6/dgjQ5mqKFbKEr5e4wV0SReU7OUrcStPRUpRpKW4lqUg/Z4U= X-Gm-Gg: AYBFou3LuaLBP4W04k5nxuS4/G3rayAtI4BZ7awxyNbEHY89sapsRj8aBsW5pwAXOtc RRmfqbfdCBg2XF44fzzMFoQtUciemapT8gf9XEecYQ1BBg8EyoZc3qDqxXHl4DeW4wq6oLc1b9e gleV8gvYYMTu49V4/ZuoiGRqi22W6GZAMpNdrZGUEOlnjS/rCFK/OifY+7ELV5naYhzOMyeD2ii xOL/yNHIJlu6ADqB/ugzzjNEeixw6Bx8B92idgD5oclse/axi5u49050CQeWerTApftFQI9ZjtL 7Qblnr0qQHQig0PRIAAe1lajkEQ5koEXrJVvtKS2R4OaTizgVRMFwpS7E2ElsdiAqT+Xwjle0ZT MhOThuR6sXIBIcVIW61/2tI9FuvumdQJFj2LFDMXvAwitP4DMvNkXd9c/xcjvhkrtisq3++J5We gDwIUgf7BBSAK+9pCZFJmnAEOFmVHX8R3sBHwsqqaZPGxCiH75EHHSmfbREELX1qUcAdwjhwKHt BQ= X-Received: by 2002:a05:600c:548e:b0:49f:f9d1:e618 with SMTP id 5b1f17b1804b1-4a18e4aa057mr205547665e9.17.1791837811442; Mon, 12 Oct 2026 13:43:31 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4a199e5db12sm197660805e9.2.2026.10.12.13.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 13:43:30 -0700 (PDT) Date: Mon, 12 Oct 2026 22:43:29 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Kishore Batta Cc: Jonathan Corbet , Shuah Khan , Jeff Hugo , Carl Vanderlip , Oded Gabbay , Manivannan Sadhasivam , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, mhi@lists.linux.dev Subject: Re: [PATCH v8 2/7] bus: mhi: Move Sahara protocol driver under MHI host client drivers Message-ID: References: <20261012-sahara_protocol_new_v2-v8-0-e12939d229a1@oss.qualcomm.com> <20261012-sahara_protocol_new_v2-v8-2-e12939d229a1@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k75v5fxmll73bi5h" Content-Disposition: inline In-Reply-To: <20261012-sahara_protocol_new_v2-v8-2-e12939d229a1@oss.qualcomm.com> --k75v5fxmll73bi5h Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v8 2/7] bus: mhi: Move Sahara protocol driver under MHI host client drivers MIME-Version: 1.0 On Mon, Oct 12, 2026 at 11:48:00PM +0530, Kishore Batta wrote: > #include > #include > #include > #include > +#include Why? There isn't even a (new) usage of any *_device_id. There is a mhi_device_id, please rely on linux/mhi.h to provide that. The main effect of including linux/mod_devicetable.h is that the driver grows many unneeded dependencies, so don't. Best regards Uwe --k75v5fxmll73bi5h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrNRm4ACgkQj4D7WH0S /k4JaAf+LQbc81GUcwrqUE1hp5/ZCb05DUb37f03Yl819y3z00pXYZgwXJDUTd9T GxJKc/iB9t1KKUv41uObbdOWw/pX8fpB4QMUgZQ1hlt7cRumJE11HOvk3ieg5WNf pb4dIHEZGziIGLgCybUc7cofDnbPzwRnzZHOM7ngjQ1pg6U7wFlwInyjQD9mkett cBtgIfwxlb61WfBOpmn2HajtmR/jVHmrj28oEqs6rJYH4yqR5eDpna/VhGCLfSV6 /AGqL77ZVNBz+bljTJO/GmIXlHHKNMQ9siCwfbX8dqLVG+HqxQB9+07RAtKA7t3q ehCntiPriE7DoQa/XfRDpRlCwDiqzA== =+TQr -----END PGP SIGNATURE----- --k75v5fxmll73bi5h--