From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: raffaele.tranfaglia@gmail.com,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux@analog.com, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: addac: adt7316: use dev_err_probe() for ldac GPIO
Date: Tue, 13 Oct 2026 00:27:15 +0300 [thread overview]
Message-ID: <as1Qs5H5-SG3gik4@ashevche-desk.local> (raw)
In-Reply-To: <aszvaazebS2NISxS@nsa>
On Mon, Oct 12, 2026 at 03:35:30PM +0100, Nuno Sá wrote:
> On Sun, Oct 11, 2026 at 07:56:22PM +0100, Raffaele Tranfaglia via B4 Relay wrote:
> > Use dev_err_probe() when requesting the ldac GPIO fails. This
> > avoids logging an error when the GPIO controller is not ready yet
> > and the request returns -EPROBE_DEFER, and records the deferral
> > reason. It also simplifies the error path.
> Not sure what's Jonathan policy in here (or don't remember :)).
> Personally, I don't see much benefit on this kind of patches. I'm aware
> you might be eager to have something upstream but for staging I guess
> the real value is in having someone willing to really cleanup the driver
> so that we can take it out of staging (naturally that also means having
> HW or someone willing to test it).
This is a real fix for a (rare enough) problem. Without this it's possible
to get your dmesg flooded with the messages instead of the useful logs, so
I'm definitely in favour of taking it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-12 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 18:56 Raffaele Tranfaglia via B4 Relay
2026-10-12 14:35 ` Nuno Sá
2026-10-12 21:27 ` Andy Shevchenko [this message]
2026-10-12 21:28 ` Andy Shevchenko
2026-10-13 7:50 ` Joshua Crofts
2026-10-13 8:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as1Qs5H5-SG3gik4@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=raffaele.tranfaglia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®